You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/09 03:28:52 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #23111: Use existing pickle_library flag in expansion service.

tvalentyn commented on code in PR #23111:
URL: https://github.com/apache/beam/pull/23111#discussion_r966590009


##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -449,8 +449,7 @@ public OutputT expand(InputT input) {
       } else {
         int port = PythonService.findAvailablePort();
         ImmutableList.Builder<String> args = ImmutableList.builder();
-        args.add(
-            "--port=" + port, "--fully_qualified_name_glob=*", "--default_pickler=cloudpickle");
+        args.add("--port=" + port, "--fully_qualified_name_glob=*", "--pickle_library=cloudpickle");

Review Comment:
   this only applies to external transforms where Python transform is called from Java. this is new functionality and there are not a lot of tests to break. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org