[jira] [Comment Edited] (FLINK-15841) TimeWindow.intersects return true for consecutive windows

["Jörn Kottmann (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029216#comment-17029216 ] 

Jörn Kottmann edited comment on FLINK-15841 at 2/3/20 7:31 PM:
---------------------------------------------------------------

Just tried it now, there are many test failures after the change.

I could try to work through them. Is there an interest to get this fixed?


was (Author: joern):
Just tried it now, there are many test failures after the change.

I could try to work through them Is there an interest to get this fixed?

> TimeWindow.intersects return true for consecutive windows
> ---------------------------------------------------------
>
>                 Key: FLINK-15841
>                 URL: https://issues.apache.org/jira/browse/FLINK-15841
>             Project: Flink
>          Issue Type: Bug
>          Components: API / DataStream
>            Reporter: Jörn Kottmann
>            Assignee: Jörn Kottmann
>            Priority: Trivial
>
> The TimeWindow JavaDoc explains that the start index is inclusive and the end index is exclusive, therefore two windows T0 to T1 and T1 to T2 are next to each other without overlapping.
> To fix this the intersects comparison should be changed to: {{this.start < other.end && this.end > other.start}}
> Also a test should be added to verify the methods works correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)