[GitHub] [thrift] andrewcunnin commented on a diff in pull request #2783: [THRIFT-5693] - fix bug in serialization of enum default values

["andrewcunnin (via GitHub)" <gi...@apache.org>]

andrewcunnin commented on code in PR #2783:
URL: https://github.com/apache/thrift/pull/2783#discussion_r1165817977


##########
test/ThriftTest.thrift:
##########
@@ -112,7 +112,7 @@ struct CrazyNesting {
   // Do not insert line break as test/go/Makefile.am is removing this line with pattern match
   3: required list<map<set<i32> (python.immutable = ""), map<i32,set<list<map<Insanity,string>(python.immutable = "")> (python.immutable = "")>>>> list_field,
   4: binary binary_field
-  5: uuid uuid_field
+  // 5: uuid uuid_field

Review Comment:
   ```suggestion
     5: uuid uuid_field
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org