You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "tanmaya-panda1 (via GitHub)" <gi...@apache.org> on 2023/05/29 11:19:05 UTC
[GitHub] [nifi] tanmaya-panda1 commented on a diff in pull request #7122: NIFI-8294 ADX as source for various NIFI destinations
tanmaya-panda1 commented on code in PR #7122:
URL: https://github.com/apache/nifi/pull/7122#discussion_r1209211426
##########
nifi-nar-bundles/nifi-adx-bundle/nifi-adx-processors/src/main/java/org/apache/nifi/processors/adx/QueryAzureDataExplorer.java:
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.adx;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nifi.adx.AdxSourceConnectionService;
+import org.apache.nifi.adx.model.KustoQueryResponse;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.adx.enums.AzureAdxSourceProcessorParameter;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"azure", "adx", "microsoft", "data", "explorer", "source"})
+@CapabilityDescription("This Processor acts as a ADX source connector which queries data from Azure Data Explorer."+
+ "This connector can act only as a start of the data pipeline getting data from ADX."+
+ "The queries which can be used further details can be found here https://learn.microsoft.com/en-us/azure/data-explorer/kusto/concepts/querylimits")
+@WritesAttributes({
+ @WritesAttribute(attribute = QueryAzureDataExplorer.ADX_QUERY_ERROR_MESSAGE, description = "Azure Data Explorer error message."),
+ @WritesAttribute(attribute = QueryAzureDataExplorer.ADX_EXECUTED_QUERY, description = "Azure Data Explorer executed query.")
+})
+public class QueryAzureDataExplorer extends AbstractProcessor {
+ public static final String ADX_QUERY_ERROR_MESSAGE = "adx.query.error.message";
+ public static final String ADX_EXECUTED_QUERY = "adx.executed.query";
+
+ public static final Relationship SUCCESS = new Relationship.Builder()
+ .name("SUCCESS")
+ .description("Relationship for success")
+ .build();
+ public static final Relationship FAILED = new Relationship.Builder()
+ .name("FAILED")
+ .description("Relationship for failure")
+ .build();
+ public static final PropertyDescriptor DB_NAME = new PropertyDescriptor
+ .Builder().name(AzureAdxSourceProcessorParameter.DB_NAME.name())
+ .displayName(AzureAdxSourceProcessorParameter.DB_NAME.getParamDisplayName())
+ .description(AzureAdxSourceProcessorParameter.DB_NAME.getParamDescription())
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+ public static final PropertyDescriptor ADX_QUERY = new PropertyDescriptor
+ .Builder().name(AzureAdxSourceProcessorParameter.ADX_QUERY.name())
+ .displayName(AzureAdxSourceProcessorParameter.ADX_QUERY.getParamDisplayName())
+ .description(AzureAdxSourceProcessorParameter.ADX_QUERY.getParamDescription())
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+ public static final PropertyDescriptor ADX_SOURCE_SERVICE = new PropertyDescriptor
+ .Builder().name(AzureAdxSourceProcessorParameter.ADX_SOURCE_SERVICE.name())
+ .displayName(AzureAdxSourceProcessorParameter.ADX_SOURCE_SERVICE.getParamDisplayName())
+ .description(AzureAdxSourceProcessorParameter.ADX_SOURCE_SERVICE.getParamDescription())
+ .required(true)
+ .identifiesControllerService(AdxSourceConnectionService.class)
+ .build();
+ private final ObjectMapper objectMapper = new ObjectMapper();
+ private final Set<Relationship> relationships = Set.of(SUCCESS,FAILED);
+ private final List<PropertyDescriptor> descriptors = List.of(ADX_SOURCE_SERVICE,DB_NAME,ADX_QUERY);
+ private AdxSourceConnectionService service;
+
+ @Override
+ public Set<Relationship> getRelationships() {
+ return this.relationships;
+ }
+
+ @Override
+ public final List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return descriptors;
+ }
+
+ @OnScheduled
+ public void onScheduled(final ProcessContext context) {
+ service = context.getProperty(ADX_SOURCE_SERVICE).asControllerService(AdxSourceConnectionService.class);
+ }
+
+ @Override
+ public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
+ FlowFile outgoingFlowFile;
+ String databaseName = context.getProperty(DB_NAME).getValue();
+ String adxQuery;
+ KustoQueryResponse kustoQueryResponse;
+
+ //checks if this processor has any preceding connection, if yes retrieve
+ if (context.hasIncomingConnection()) {
+ FlowFile incomingFlowFile = session.get();
+ //incoming connection exists but the incoming flowfile is null
+ if (incomingFlowFile == null && context.hasNonLoopConnection()) {
+ return;
+ }
+ //incoming connection exists and retrieve adxQuery from context
+ if (incomingFlowFile != null && incomingFlowFile.getSize() == 0) {
+ if (context.getProperty(ADX_QUERY).isSet()) {
+ adxQuery = context.getProperty(ADX_QUERY).evaluateAttributeExpressions(incomingFlowFile).getValue();
+ } else {
+ String message = "FlowFile query is empty and no scheduled query is set";
+ getLogger().error(message);
+ incomingFlowFile = session.putAttribute(incomingFlowFile, ADX_QUERY_ERROR_MESSAGE, message);
+ session.transfer(incomingFlowFile, FAILED);
+ return;
+ }
+ } else {
+ try {
+ adxQuery = getQuery(session, incomingFlowFile);
+ } catch(IOException ioe) {
+ throw new ProcessException("Failed to read Query from FlowFile",ioe);
+ }
+ }
+ outgoingFlowFile = incomingFlowFile;
+ } else {
+ outgoingFlowFile = session.create();
+ adxQuery = context.getProperty(ADX_QUERY).evaluateAttributeExpressions(outgoingFlowFile).getValue();
+ }
+
+ try {
+ //execute Query
+ kustoQueryResponse = executeQuery(databaseName,adxQuery);
+ if(!kustoQueryResponse.isError()){
+ try(ByteArrayInputStream bais = new ByteArrayInputStream(objectMapper.writeValueAsBytes(kustoQueryResponse.getTableData()))){
+ session.importFrom(bais, outgoingFlowFile);
+ }
Review Comment:
makes sense @exceptionfactory, fixed as advised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org