You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jiangzho (via GitHub)" <gi...@apache.org> on 2025/08/07 22:57:48 UTC

[PR] [SPARK-53187]Support SparkCluster event related metrics set [spark-kubernetes-operator]

jiangzho opened a new pull request, #295:
URL: https://github.com/apache/spark-kubernetes-operator/pull/295

   ### What changes were proposed in this pull request?
   
   This PR adds SparkCluster as a supported type in metrics and therefore supports publishing execution metrics for it.
   
   ### Why are the changes needed?
   
   Operator by default publish metrics by resource type (SparkApplication) - by adding this support, we support the same set of counter and histogram for received event and timed execution
   
   ### Does this PR introduce _any_ user-facing change?
   
   More Metrics becomes available for SparkClusters
   
   ### How was this patch tested?
   
   From dev sandbox we can see metrics like
   
   ```
   metrics_operator.sdk_sparkapplication_added_resource_event_Count{type="counters"} 9010
   metrics_operator.sdk_sparkapplication_reconciliation_failed_Count{type="counters"} 9
   metrics_operator.sdk_sparkapplication_reconciliation_finished_Count{type="counters"} 182841
   metrics_operator.sdk_sparkapplication_reconciliation_retries_Count{type="counters"} 9
   metrics_operator.sdk_sparkcluster_added_resource_event_Count{type="counters"} 9009
   metrics_operator.sdk_sparkcluster_reconciliation_failed_Count{type="counters"} 0
   metrics_operator.sdk_sparkcluster_reconciliation_finished_Count{type="counters"} 182821
   metrics_operator.sdk_sparkcluster_reconciliation_retries_Count{type="counters"} 0
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53187]Support SparkCluster event related metrics set [spark-kubernetes-operator]

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth closed pull request #295: [SPARK-53187]Support SparkCluster event related metrics set
URL: https://github.com/apache/spark-kubernetes-operator/pull/295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53187]Support SparkCluster event related metrics set [spark-kubernetes-operator]

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #295:
URL: https://github.com/apache/spark-kubernetes-operator/pull/295#issuecomment-3167521572

   Thanks for the PR @jiangzho!
   
   Merged to `main` (0.5.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53187]Support SparkCluster event related metrics set [spark-kubernetes-operator]

Posted by "jiangzho (via GitHub)" <gi...@apache.org>.
jiangzho commented on PR #295:
URL: https://github.com/apache/spark-kubernetes-operator/pull/295#issuecomment-3166072875

   cc @peter-toth for review. Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org