You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/18 23:22:34 UTC

[GitHub] [helix] qqu0127 commented on a change in pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor

qqu0127 commented on a change in pull request #1986:
URL: https://github.com/apache/helix/pull/1986#discussion_r830401436



##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -269,7 +269,10 @@ public ZKHelixManager(String clusterName, String instanceName, InstanceType inst
     }
 
     _stateListener = stateListener;
+    // read cloud config from ZK and set cloudConfig in HelixManagerProperty
     _helixManagerProperty = helixManagerProperty;
+    _helixManagerProperty
+        .setHelixCloudProperty(HelixPropertyFactory.getCloudConfig(_zkAddress, _clusterName));

Review comment:
       Maybe not related, what the difference between this and using `_configAccessor.getCloudConfig()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org