[GitHub] spark pull request: [SPARK-15681][core] allow lowercase or mixed case log le...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13422#discussion_r65284155
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -357,7 +357,8 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
        */
       def setLogLevel(logLevel: String) {
         val validLevels = Seq("ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF", "TRACE", "WARN")
    -    if (!validLevels.contains(logLevel)) {
    +    // let's allow lowcase or mixed case too
    +    if (!validLevels.contains(logLevel.toUpperCase(Locale.ENGLISH))) {
    --- End diff --
    
    You could use `require` here even.
    My suggestion was to use a `Set` above, and, to make it a static member of an object. However, maybe that's really trivial since this method is called so infrequently.
    I do think it's best to pass the value to log4j that is validated here -- the uppercase version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org