You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/14 20:10:04 UTC

[GitHub] [zookeeper] tudor opened a new pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

tudor opened a new pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403


   See the comments in the JIRA issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-667159006


   Thanks @tudor for your fix!
   I pushed to all active branches (and also executing C unit tests for all branches, as CI only is checking the master).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-658388865


   @ztzg @symat can you please take a look ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-666968584


   thanks @ztzg for the feedback, really appreciated!
   @eolivelli are you OK if we merge it? The C-client changes rarely get reviews from other committers... @nkalmar maybe?
   As this is a bugfix (no new feature, but fixing a segfault), I think it would be great to have this on all active branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-658848348


   Sorry, I'm on vacation without a laptop. I'll check it next week, if others doesn't approve it sooner.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-665462811


   Hi @tudor, @symat,
   
   Sorry for the delay; I've been a bit "disconnected" and almost missed this.  I'll have a look ASAP.
   
   Cheers, -D
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1403: ZOOKEEPER-3885: add locking for watchers hashtables

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1403:
URL: https://github.com/apache/zookeeper/pull/1403#issuecomment-661042885






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org