You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/21 04:01:44 UTC
[GitHub] [flink] RocMarshal opened a new pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
RocMarshal opened a new pull request #14710:
URL: https://github.com/apache/flink/pull/14710
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764262487
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312",
"triggerID" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"triggerType" : "PUSH"
}, {
"hash" : "19b21f139295e1982a0bd5f09e60bd6551226621",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19b21f139295e1982a0bd5f09e60bd6551226621",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312)
* 19b21f139295e1982a0bd5f09e60bd6551226621 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764262487
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312",
"triggerID" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764632952
@XBaith @klion26 Could you help me to review this PR?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on a change in pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
fsk119 commented on a change in pull request #14710:
URL: https://github.com/apache/flink/pull/14710#discussion_r564455050
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -63,24 +54,25 @@ val:
{% endhighlight %}
-### Examples
+<a name="examples"></a>
+### 示例
{% highlight sql %}
CREATE TABLE kafka_table1 (id BIGINT, name STRING, age INT) WITH (...);
CREATE TABLE kafka_table2 (id BIGINT, name STRING, age INT) WITH (...);
--- override table options in query source
+-- 在查询源中覆盖表选项
Review comment:
覆盖查询语句中源表的选项
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -63,24 +54,25 @@ val:
{% endhighlight %}
-### Examples
+<a name="examples"></a>
+### 示例
{% highlight sql %}
CREATE TABLE kafka_table1 (id BIGINT, name STRING, age INT) WITH (...);
CREATE TABLE kafka_table2 (id BIGINT, name STRING, age INT) WITH (...);
--- override table options in query source
+-- 在查询源中覆盖表选项
select id, name from kafka_table1 /*+ OPTIONS('scan.startup.mode'='earliest-offset') */;
--- override table options in join
+-- 在 join 中覆盖表选项
select * from
kafka_table1 /*+ OPTIONS('scan.startup.mode'='earliest-offset') */ t1
join
kafka_table2 /*+ OPTIONS('scan.startup.mode'='earliest-offset') */ t2
on t1.id = t2.id;
--- override table options for INSERT target table
+-- 对 INSERT 目标表使用覆盖表选项
Review comment:
覆盖插入语句中结果表的选项
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -63,24 +54,25 @@ val:
{% endhighlight %}
-### Examples
+<a name="examples"></a>
+### 示例
{% highlight sql %}
CREATE TABLE kafka_table1 (id BIGINT, name STRING, age INT) WITH (...);
CREATE TABLE kafka_table2 (id BIGINT, name STRING, age INT) WITH (...);
--- override table options in query source
+-- 在查询源中覆盖表选项
select id, name from kafka_table1 /*+ OPTIONS('scan.startup.mode'='earliest-offset') */;
--- override table options in join
+-- 在 join 中覆盖表选项
Review comment:
覆盖 join 中源表的选项
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -25,34 +25,25 @@ under the License.
* This will be replaced by the TOC
{:toc}
-SQL hints can be used with SQL statements to alter execution plans. This chapter explains how to use hints to force various approaches.
-
-Generally a hint can be used to:
-
-- Enforce planner: there's no perfect planner, so it makes sense to implement hints to
-allow user better control the execution;
-- Append meta data(or statistics): some statistics like “table index for scan” and
-“skew info of some shuffle keys” are somewhat dynamic for the query, it would be very
-convenient to config them with hints because our planning metadata from the planner is very
-often not that accurate;
-- Operator resource constraints: for many cases, we would give a default resource
-configuration for the execution operators, i.e. min parallelism or
-managed memory (resource consuming UDF) or special resource requirement (GPU or SSD disk)
-and so on, it would be very flexible to profile the resource with hints per query(instead of the Job).
-
-## Dynamic Table Options
-Dynamic table options allows to specify or override table options dynamically, different with static table options defined with SQL DDL or connect API,
-these options can be specified flexibly in per-table scope within each query.
-
-Thus it is very suitable to use for the ad-hoc queries in interactive terminal, for example, in the SQL-CLI,
-you can specify to ignore the parse error for a CSV source just by adding a dynamic option `/*+ OPTIONS('csv.ignore-parse-errors'='true') */`.
-
-<b>Note:</b> Dynamic table options default is forbidden to use because it may change the semantics of the query.
-You need to set the config option `table.dynamic-table-options.enabled` to be `true` explicitly (default is false),
-See the <a href="{% link dev/table/config.zh.md %}">Configuration</a> for details on how to set up the config options.
-
-### Syntax
-In order to not break the SQL compatibility, we use the Oracle style SQL hint syntax:
+可以将 SQL 提示（hints）与 SQL 语句一起使用改变执行计划（execution plans）。本章介绍如何使用 SQL 提示增强各种方法。
+
+SQL 提示一般可以用于以下：
+
+- Enforce planner：没有十分契合的 planner，所以实现提示让用户更好地控制执行是十分有意义的；
+- 增加元数据（或者统计信息）：如 "table index for scan" 和 "skew info of some shuffle keys" 的一些统计数据对于查询来说是动态的，用提示来配置它们会非常方便，因为我们从 planner 获得的计划元数据通常不那么准确；
Review comment:
Please also translate the "table index for scan" and "skew info of some shuffle keys".
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -25,34 +25,25 @@ under the License.
* This will be replaced by the TOC
{:toc}
-SQL hints can be used with SQL statements to alter execution plans. This chapter explains how to use hints to force various approaches.
-
-Generally a hint can be used to:
-
-- Enforce planner: there's no perfect planner, so it makes sense to implement hints to
-allow user better control the execution;
-- Append meta data(or statistics): some statistics like “table index for scan” and
-“skew info of some shuffle keys” are somewhat dynamic for the query, it would be very
-convenient to config them with hints because our planning metadata from the planner is very
-often not that accurate;
-- Operator resource constraints: for many cases, we would give a default resource
-configuration for the execution operators, i.e. min parallelism or
-managed memory (resource consuming UDF) or special resource requirement (GPU or SSD disk)
-and so on, it would be very flexible to profile the resource with hints per query(instead of the Job).
-
-## Dynamic Table Options
-Dynamic table options allows to specify or override table options dynamically, different with static table options defined with SQL DDL or connect API,
-these options can be specified flexibly in per-table scope within each query.
-
-Thus it is very suitable to use for the ad-hoc queries in interactive terminal, for example, in the SQL-CLI,
-you can specify to ignore the parse error for a CSV source just by adding a dynamic option `/*+ OPTIONS('csv.ignore-parse-errors'='true') */`.
-
-<b>Note:</b> Dynamic table options default is forbidden to use because it may change the semantics of the query.
-You need to set the config option `table.dynamic-table-options.enabled` to be `true` explicitly (default is false),
-See the <a href="{% link dev/table/config.zh.md %}">Configuration</a> for details on how to set up the config options.
-
-### Syntax
-In order to not break the SQL compatibility, we use the Oracle style SQL hint syntax:
+可以将 SQL 提示（hints）与 SQL 语句一起使用改变执行计划（execution plans）。本章介绍如何使用 SQL 提示增强各种方法。
Review comment:
I think it's better to not translate the word `hints`. After I search with key words `sql hints` in baidu.com, I get more results about auto complete.
I think it's better to translate to
```
SQL hints 是和SQL语句一起使用来改变执行计划的。
```
##########
File path: docs/dev/table/sql/hints.zh.md
##########
@@ -25,34 +25,25 @@ under the License.
* This will be replaced by the TOC
{:toc}
-SQL hints can be used with SQL statements to alter execution plans. This chapter explains how to use hints to force various approaches.
-
-Generally a hint can be used to:
-
-- Enforce planner: there's no perfect planner, so it makes sense to implement hints to
-allow user better control the execution;
-- Append meta data(or statistics): some statistics like “table index for scan” and
-“skew info of some shuffle keys” are somewhat dynamic for the query, it would be very
-convenient to config them with hints because our planning metadata from the planner is very
-often not that accurate;
-- Operator resource constraints: for many cases, we would give a default resource
-configuration for the execution operators, i.e. min parallelism or
-managed memory (resource consuming UDF) or special resource requirement (GPU or SSD disk)
-and so on, it would be very flexible to profile the resource with hints per query(instead of the Job).
-
-## Dynamic Table Options
-Dynamic table options allows to specify or override table options dynamically, different with static table options defined with SQL DDL or connect API,
-these options can be specified flexibly in per-table scope within each query.
-
-Thus it is very suitable to use for the ad-hoc queries in interactive terminal, for example, in the SQL-CLI,
-you can specify to ignore the parse error for a CSV source just by adding a dynamic option `/*+ OPTIONS('csv.ignore-parse-errors'='true') */`.
-
-<b>Note:</b> Dynamic table options default is forbidden to use because it may change the semantics of the query.
-You need to set the config option `table.dynamic-table-options.enabled` to be `true` explicitly (default is false),
-See the <a href="{% link dev/table/config.zh.md %}">Configuration</a> for details on how to set up the config options.
-
-### Syntax
-In order to not break the SQL compatibility, we use the Oracle style SQL hint syntax:
+可以将 SQL 提示（hints）与 SQL 语句一起使用改变执行计划（execution plans）。本章介绍如何使用 SQL 提示增强各种方法。
+
+SQL 提示一般可以用于以下：
+
+- Enforce planner：没有十分契合的 planner，所以实现提示让用户更好地控制执行是十分有意义的；
Review comment:
enforce planner -> 增强planner
perfect -> 完美。
实现提示让用户 -> 通过提示，用户
这里主要是表达 任何优化都可能有bad case，需要人手动优化。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-767602787
@fsk119 Thank you for your comments. And I made some changes based on your suggestions. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764230111
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 19b21f139295e1982a0bd5f09e60bd6551226621 (Fri May 28 08:07:19 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-766280734
cc @fsk119 , could you help to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14710:
URL: https://github.com/apache/flink/pull/14710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764632952
@XBaith @klion26 Could you help me to review this PR?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764262487
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764632952
@XBaith Could you help me to review this PR?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-768006291
@wuchong I made some changes based on fsk119's suggestions. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764262487
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312",
"triggerID" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-766276114
@wuchong Could you help me to review this PR?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764230111
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb (Thu Jan 21 04:04:52 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764230111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764632952
@XBaith Could you help me to review this PR?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14710: [FLINK-19393][docs-zh] Translate the 'SQL Hints' page of 'Table API & SQL' into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14710:
URL: https://github.com/apache/flink/pull/14710#issuecomment-764262487
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12312",
"triggerID" : "da3f3f6a21306e3b4fa3cfc7b79ef34d825f5efb",
"triggerType" : "PUSH"
}, {
"hash" : "19b21f139295e1982a0bd5f09e60bd6551226621",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12521",
"triggerID" : "19b21f139295e1982a0bd5f09e60bd6551226621",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19b21f139295e1982a0bd5f09e60bd6551226621 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12521)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org