You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2018/06/01 20:44:51 UTC

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66716/#review204202
-----------------------------------------------------------



Looks great! 

Has this been load-tested? Do we know how many concurrent machines with coordinator tasks can be put into maintenance before it starts to affect offer processing, etc.?

- David McLaughlin


On May 26, 2018, 1:13 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66716/
> -----------------------------------------------------------
> 
> (Updated May 26, 2018, 1:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and Stephan Erb.
> 
> 
> Bugs: AURORA-1978
>     https://issues.apache.org/jira/browse/AURORA-1978
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> `Tasks` can specify custom SLA requirements as part of
> their `TaskConfig`. One of the new features is the ability
> to specify an external coordinator that can ACK/NACK
> maintenance requests for tasks. This will be hugely
> beneficial for onboarding services that cannot satisfactorily
> specify SLA in terms of running instances.
> 
> Maintenance requests are driven from the Scheduler to
> improve management of nodes in the cluster.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift ff48000d613ceef3e03586b94944d13275fb127c 
>   docs/README.md 166bf1ce240474f0a181e023439cfbfbe7363822 
>   docs/features/sla-requirements.md PRE-CREATION 
>   docs/operations/configuration.md 85a6fab54e03d52e42ba7d4ff47ab93f5b8293ee 
>   docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 
>   docs/reference/scheduler-configuration.md a659cfac974059b04ef5593286011decbb7f9110 
>   examples/vagrant/systemd/aurora-scheduler.service 57e4bba858672f8da94eaa0499f8e5f3347ab982 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java ffc07443fae9e5216a5333ae305f75aa9b452a0c 
>   src/main/java/org/apache/aurora/scheduler/config/CliOptions.java a2fb0393ba47e876c4c8c63e3ed27ebe42cb6ca3 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 3b4df55a05873e79aae206b117cbc753fa3abb94 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 25ed474289f369e74c24e999ad97ed6810c9fd5e 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java f58c66aaebe8d31913d67a05add0f3d6054e88d1 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 0e0f90b670bbbcd6cb3aa302ce4a9abfe70ea979 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java e88cad6cf12312512e6840329db7ca7134ceaae6 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9fc0416086dd3eb2e2f4e8f659da59fcdea2b22b 
>   src/main/python/apache/aurora/admin/admin_util.py 8240e8093160623b4c30dd212a88b8e122fd9856 
>   src/main/python/apache/aurora/admin/host_maintenance.py 83fc2b6ece40d3436cc7de7a034f95224235fcfd 
>   src/main/python/apache/aurora/admin/maintenance.py 942a237f47a6e0416bbaf244278685477e0f407d 
>   src/main/python/apache/aurora/client/api/__init__.py f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/client/cli/context.py 06b194114a7f44a61943e0932973e71b53f239b4 
>   src/main/python/apache/aurora/client/cli/jobs.py 536d04a21d32c4e586dc943a6f9b0ad0143354a3 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 63c338e5bbdf60de0fba8d68c6613904abb93fa8 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 8c1f5ce6d7eb94ec4e0302bfd41318bd0797a1a5 
>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java e66ec116112df164106598d9ff0bc9e8f465e44f 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 749ffeac6cb851f32bba7606390203d7a046a0e6 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 0fabb3370713e57d417adbd2af9e24a4d515c60a 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java b7dcf3af366c9def63165dc9bef998ab5e95ed49 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java c6163bbabc7e7748f167b679893a93f58e4ef1ac 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java d37e7a07e9258bc8c0758bf50aece5b79025126b 
>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 770846e84e9980ea3dbf9e1c46b0d45c5488c5b3 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java d412090c292691305f01bccd1596fb0f6bb003ad 
>   src/test/python/apache/aurora/admin/test_maintenance.py ca0239b157f9f9053821af0328b9448703386cd4 
>   src/test/python/apache/aurora/api_util.py 3fc9b478cc9aada0503e8ed8698a37b4ed926cdd 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f2a2eae1539f7f6dff6855e4122cc41c6cbb0f7b 
>   src/test/python/apache/aurora/client/cli/test_add.py b22b9f72fbddb553bfc33b1bd8e10636a8d887a6 
>   src/test/python/apache/aurora/client/cli/test_kill.py 0e859dc8618a044b2a4a6f73f45cab4a7ffcce4e 
>   src/test/sh/org/apache/aurora/e2e/http_example.py ba7d11429b5f3945a1fdf1808105b11e6ef78420 
>   src/test/sh/org/apache/aurora/e2e/partition_aware.aurora 7ea9fadefcb4846cfe4922e11febec74c75f15db 
>   src/test/sh/org/apache/aurora/e2e/sla_coordinator.py PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/sla_policy.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 888efe4e990913d81335f1f3e2c9b6473de7bee8 
>   ui/src/main/js/components/TaskConfigSummary.js 64880f4bd5c5358287ef481df455f6355fedd7d6 
> 
> 
> Diff: https://reviews.apache.org/r/66716/diff/14/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

> On June 1, 2018, 1:44 p.m., David McLaughlin wrote:
> > Looks great! 
> > 
> > Has this been load-tested? Do we know how many concurrent machines with coordinator tasks can be put into maintenance before it starts to affect offer processing, etc.?
> 
> Santhosh Kumar Shanmugham wrote:
>     Load testing results show that there is no significant impact on offer processing or scheduling. A mixed load of bad-coordinator endpoints and long-delay coordinators were used.

FYI, I was able to put ~1500 hosts into maintenance and push the parallelism upto 1000 without any impact.


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66716/#review204202
-----------------------------------------------------------


On June 4, 2018, 8:35 p.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66716/
> -----------------------------------------------------------
> 
> (Updated June 4, 2018, 8:35 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and Stephan Erb.
> 
> 
> Bugs: AURORA-1978
>     https://issues.apache.org/jira/browse/AURORA-1978
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> `Tasks` can specify custom SLA requirements as part of
> their `TaskConfig`. One of the new features is the ability
> to specify an external coordinator that can ACK/NACK
> maintenance requests for tasks. This will be hugely
> beneficial for onboarding services that cannot satisfactorily
> specify SLA in terms of running instances.
> 
> Maintenance requests are driven from the Scheduler to
> improve management of nodes in the cluster.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift ff48000d613ceef3e03586b94944d13275fb127c 
>   docs/README.md 166bf1ce240474f0a181e023439cfbfbe7363822 
>   docs/features/sla-requirements.md PRE-CREATION 
>   docs/operations/configuration.md 85a6fab54e03d52e42ba7d4ff47ab93f5b8293ee 
>   docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 
>   docs/reference/scheduler-configuration.md a659cfac974059b04ef5593286011decbb7f9110 
>   examples/vagrant/systemd/aurora-scheduler.service 57e4bba858672f8da94eaa0499f8e5f3347ab982 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java ffc07443fae9e5216a5333ae305f75aa9b452a0c 
>   src/main/java/org/apache/aurora/scheduler/config/CliOptions.java a2fb0393ba47e876c4c8c63e3ed27ebe42cb6ca3 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 3b4df55a05873e79aae206b117cbc753fa3abb94 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 25ed474289f369e74c24e999ad97ed6810c9fd5e 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java f58c66aaebe8d31913d67a05add0f3d6054e88d1 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 0e0f90b670bbbcd6cb3aa302ce4a9abfe70ea979 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java e88cad6cf12312512e6840329db7ca7134ceaae6 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9fc0416086dd3eb2e2f4e8f659da59fcdea2b22b 
>   src/main/python/apache/aurora/admin/admin_util.py 8240e8093160623b4c30dd212a88b8e122fd9856 
>   src/main/python/apache/aurora/admin/host_maintenance.py 83fc2b6ece40d3436cc7de7a034f95224235fcfd 
>   src/main/python/apache/aurora/admin/maintenance.py 942a237f47a6e0416bbaf244278685477e0f407d 
>   src/main/python/apache/aurora/client/api/__init__.py f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/client/cli/context.py 06b194114a7f44a61943e0932973e71b53f239b4 
>   src/main/python/apache/aurora/client/cli/jobs.py 536d04a21d32c4e586dc943a6f9b0ad0143354a3 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 63c338e5bbdf60de0fba8d68c6613904abb93fa8 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 8c1f5ce6d7eb94ec4e0302bfd41318bd0797a1a5 
>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java e66ec116112df164106598d9ff0bc9e8f465e44f 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 749ffeac6cb851f32bba7606390203d7a046a0e6 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 0fabb3370713e57d417adbd2af9e24a4d515c60a 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java b7dcf3af366c9def63165dc9bef998ab5e95ed49 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java c6163bbabc7e7748f167b679893a93f58e4ef1ac 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java d37e7a07e9258bc8c0758bf50aece5b79025126b 
>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 770846e84e9980ea3dbf9e1c46b0d45c5488c5b3 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java d412090c292691305f01bccd1596fb0f6bb003ad 
>   src/test/python/apache/aurora/admin/test_maintenance.py ca0239b157f9f9053821af0328b9448703386cd4 
>   src/test/python/apache/aurora/api_util.py 3fc9b478cc9aada0503e8ed8698a37b4ed926cdd 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f2a2eae1539f7f6dff6855e4122cc41c6cbb0f7b 
>   src/test/python/apache/aurora/client/cli/test_add.py b22b9f72fbddb553bfc33b1bd8e10636a8d887a6 
>   src/test/python/apache/aurora/client/cli/test_kill.py 0e859dc8618a044b2a4a6f73f45cab4a7ffcce4e 
>   src/test/sh/org/apache/aurora/e2e/http_example.py ba7d11429b5f3945a1fdf1808105b11e6ef78420 
>   src/test/sh/org/apache/aurora/e2e/partition_aware.aurora 7ea9fadefcb4846cfe4922e11febec74c75f15db 
>   src/test/sh/org/apache/aurora/e2e/sla_coordinator.py PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/sla_policy.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 888efe4e990913d81335f1f3e2c9b6473de7bee8 
>   ui/src/main/js/components/TaskConfigSummary.js 64880f4bd5c5358287ef481df455f6355fedd7d6 
> 
> 
> Diff: https://reviews.apache.org/r/66716/diff/15/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> File Attachments
> ----------------
> 
> Load test results
>   https://reviews.apache.org/media/uploaded/files/2018/06/05/96d42678-8e61-48c8-977c-fdd925a23185__Screen_Shot_2018-06-04_at_8.14.28_PM.png
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

> On June 1, 2018, 1:44 p.m., David McLaughlin wrote:
> > Looks great! 
> > 
> > Has this been load-tested? Do we know how many concurrent machines with coordinator tasks can be put into maintenance before it starts to affect offer processing, etc.?

Load testing results show that there is no significant impact on offer processing or scheduling. A mixed load of bad-coordinator endpoints and long-delay coordinators were used.


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66716/#review204202
-----------------------------------------------------------


On May 25, 2018, 6:13 p.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66716/
> -----------------------------------------------------------
> 
> (Updated May 25, 2018, 6:13 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and Stephan Erb.
> 
> 
> Bugs: AURORA-1978
>     https://issues.apache.org/jira/browse/AURORA-1978
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> `Tasks` can specify custom SLA requirements as part of
> their `TaskConfig`. One of the new features is the ability
> to specify an external coordinator that can ACK/NACK
> maintenance requests for tasks. This will be hugely
> beneficial for onboarding services that cannot satisfactorily
> specify SLA in terms of running instances.
> 
> Maintenance requests are driven from the Scheduler to
> improve management of nodes in the cluster.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift ff48000d613ceef3e03586b94944d13275fb127c 
>   docs/README.md 166bf1ce240474f0a181e023439cfbfbe7363822 
>   docs/features/sla-requirements.md PRE-CREATION 
>   docs/operations/configuration.md 85a6fab54e03d52e42ba7d4ff47ab93f5b8293ee 
>   docs/reference/configuration.md d4b869b938105ba301fc88d41019af2f1707f6f4 
>   docs/reference/scheduler-configuration.md a659cfac974059b04ef5593286011decbb7f9110 
>   examples/vagrant/systemd/aurora-scheduler.service 57e4bba858672f8da94eaa0499f8e5f3347ab982 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java ffc07443fae9e5216a5333ae305f75aa9b452a0c 
>   src/main/java/org/apache/aurora/scheduler/config/CliOptions.java a2fb0393ba47e876c4c8c63e3ed27ebe42cb6ca3 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 4073229b74d0e0e7fd31552bd96894ceb8a0971a 
>   src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 3b4df55a05873e79aae206b117cbc753fa3abb94 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 25ed474289f369e74c24e999ad97ed6810c9fd5e 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java f58c66aaebe8d31913d67a05add0f3d6054e88d1 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 0e0f90b670bbbcd6cb3aa302ce4a9abfe70ea979 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java e88cad6cf12312512e6840329db7ca7134ceaae6 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9fc0416086dd3eb2e2f4e8f659da59fcdea2b22b 
>   src/main/python/apache/aurora/admin/admin_util.py 8240e8093160623b4c30dd212a88b8e122fd9856 
>   src/main/python/apache/aurora/admin/host_maintenance.py 83fc2b6ece40d3436cc7de7a034f95224235fcfd 
>   src/main/python/apache/aurora/admin/maintenance.py 942a237f47a6e0416bbaf244278685477e0f407d 
>   src/main/python/apache/aurora/client/api/__init__.py f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/client/cli/context.py 06b194114a7f44a61943e0932973e71b53f239b4 
>   src/main/python/apache/aurora/client/cli/jobs.py 536d04a21d32c4e586dc943a6f9b0ad0143354a3 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 63c338e5bbdf60de0fba8d68c6613904abb93fa8 
>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 8c1f5ce6d7eb94ec4e0302bfd41318bd0797a1a5 
>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java e66ec116112df164106598d9ff0bc9e8f465e44f 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 749ffeac6cb851f32bba7606390203d7a046a0e6 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 0fabb3370713e57d417adbd2af9e24a4d515c60a 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java b7dcf3af366c9def63165dc9bef998ab5e95ed49 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java c6163bbabc7e7748f167b679893a93f58e4ef1ac 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java d37e7a07e9258bc8c0758bf50aece5b79025126b 
>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 770846e84e9980ea3dbf9e1c46b0d45c5488c5b3 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java d412090c292691305f01bccd1596fb0f6bb003ad 
>   src/test/python/apache/aurora/admin/test_maintenance.py ca0239b157f9f9053821af0328b9448703386cd4 
>   src/test/python/apache/aurora/api_util.py 3fc9b478cc9aada0503e8ed8698a37b4ed926cdd 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f2a2eae1539f7f6dff6855e4122cc41c6cbb0f7b 
>   src/test/python/apache/aurora/client/cli/test_add.py b22b9f72fbddb553bfc33b1bd8e10636a8d887a6 
>   src/test/python/apache/aurora/client/cli/test_kill.py 0e859dc8618a044b2a4a6f73f45cab4a7ffcce4e 
>   src/test/sh/org/apache/aurora/e2e/http_example.py ba7d11429b5f3945a1fdf1808105b11e6ef78420 
>   src/test/sh/org/apache/aurora/e2e/partition_aware.aurora 7ea9fadefcb4846cfe4922e11febec74c75f15db 
>   src/test/sh/org/apache/aurora/e2e/sla_coordinator.py PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/sla_policy.aurora PRE-CREATION 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 888efe4e990913d81335f1f3e2c9b6473de7bee8 
>   ui/src/main/js/components/TaskConfigSummary.js 64880f4bd5c5358287ef481df455f6355fedd7d6 
> 
> 
> Diff: https://reviews.apache.org/r/66716/diff/14/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>