You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2012/04/09 19:48:20 UTC
svn propchange: r1311167 - svn:log
Author: mbautin
Revision: 1311167
Modified property: svn:log
Modified: svn:log at Mon Apr 9 17:48:20 2012
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Mon Apr 9 17:48:20 2012
@@ -1,20 +1,22 @@
-[jira] [HBASE-5744] [89-fb] Thrift server metrics should be long instead of int
+[jira] [HBASE-5744] Thrift server metrics should be long instead of int
-Summary: As we measure our Thrift call latencies in nanoseconds, we need to make
+Summary:
+As we measure our Thrift call latencies in nanoseconds, we need to make
latencies long instead of int everywhere. There is a bug where we truncate a
nanosecond latency to int, which is a problem with RPCs that take more than
2.147483647 seconds to process.
+This is a trunk diff. The 89-fb version of this diff is at D2679.
+
Test Plan:
TestThriftServer is updated to test for the failure case (an RPC is artificially
made to take 3 seconds). The new test case fails without the fix.
Re-run all unit tests.
-Reviewers: sc, dhruba, Kannan, Liyin, JIRA
+Reviewers: stack, sc, Kannan, JIRA
Reviewed By: sc
-CC: stack
+Differential Revision: https://reviews.facebook.net/D2685
-Differential Revision: https://reviews.facebook.net/D2679