You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2016/12/07 05:30:55 UTC
[GitHub] drill pull request #681: DRILL-5112: Unit tests derived from PopUnitTestBase...
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/681
DRILL-5112: Unit tests derived from PopUnitTestBase fail in IDE due to config errors
Tests rely on command-line settings in the pom.xml file. Those settings
are not available when tests are run in Eclipse. Replicated required
settings into the base test class (as in BaseTestQuery).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #681
----
commit ddccb6a6ad16e49175bb90468a7845d9fae8eaac
Author: Paul Rogers <pr...@maprtech.com>
Date: 2016-12-07T05:11:56Z
DRILL-5112: Unit tests derived from PopUnitTestBase fail in IDE due to config errors
Tests rely on command-line settings in the pom.xml file. Those settings
are not available when tests are run in Eclipse. Replicated required
settings into the base test class (as in BaseTestQuery).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #681: DRILL-5112: Unit tests derived from PopUnitTestBase...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/681
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #681: DRILL-5112: Unit tests derived from PopUnitTestBase...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/681#discussion_r91236287
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/pop/PopUnitTestBase.java ---
@@ -42,7 +46,17 @@
@BeforeClass
public static void setup() {
- CONFIG = DrillConfig.create();
+ Properties props = new Properties();
--- End diff --
Per the TypeSafe config system, command line properties override any properties here or in drill-module.conf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #681: DRILL-5112: Unit tests derived from PopUnitTestBase fail i...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/681
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---