You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "machi1990 (via GitHub)" <gi...@apache.org> on 2023/04/19 08:32:34 UTC

[GitHub] [kafka] machi1990 opened a new pull request, #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

machi1990 opened a new pull request, #13611:
URL: https://github.com/apache/kafka/pull/13611

   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1563305554

   I'll take a look @machi1990 . In the mean time, can you please add a description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1564562097

   Thanks @jsancio for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1563412353

   Thanks @jsancio I've added a description to the PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1514361633

   Hi @cmccabe @jsancio can you've a look at this, thanks?
   
   /cc @showuon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio merged pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio merged PR #13611:
URL: https://github.com/apache/kafka/pull/13611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] machi1990 commented on pull request #13611: MINOR: remove unused variable from QuorumMetaLogListener#handleCommit method

Posted by "machi1990 (via GitHub)" <gi...@apache.org>.
machi1990 commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1521610996

   Thanks for the review @divijvaidya 
   
   > Could you please check where was this added and what commit was it's usage removed? Such unused variable may be hiding bugs where they should have been used but aren't.
   > 
   
   This was added and used as part of the changes in https://github.com/apache/kafka/pull/10812 and its usage was removed in https://github.com/apache/kafka/pull/12747. The removal was part of fixing https://issues.apache.org/jira/browse/KAFKA-14300 and it seems to me that the variable was just left over from that PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org