You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2019/03/01 00:41:02 UTC

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

Hello Andrew Sherman, Thomas Marshall, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12624

to look at the new patch set (#3).

Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()
......................................................................

IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

An incoming request to a RPC service can be rejected due to either
exceeding the memory limit or maximum allowed queue length.
It's unclear from the current error message which of those factors
contributes to the failure as neither the actual queue length nor
the memory consumption is printed.

This patch fixes the problem by printing the estimated queue length
and memory consumption when a RPC request is dropped.

Testing done: verified the new error message with test_rpc_timeout.py

Change-Id: If0297658acf2b23823dcb7d2bdff5d8e4475bb98
---
M be/src/rpc/impala-service-pool.cc
M be/src/rpc/impala-service-pool.h
2 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/12624/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0297658acf2b23823dcb7d2bdff5d8e4475bb98
Gerrit-Change-Number: 12624
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>