You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Don Brown (JIRA)" <ji...@apache.org> on 2006/07/19 04:14:21 UTC

[jira] Updated: (WW-1328) Implement theme inheritance

     [ http://issues.apache.org/struts/browse/WW-1328?page=all ]

Don Brown updated WW-1328:
--------------------------

          Summary: Implement theme inheritance  (was: xhtml theme is hardcoded to use xhtml/controlfooter for all templates)
       Issue Type: New Feature  (was: Bug)
    Fix Version/s: 2.0.1
                       (was: 2.0.0)

Looking into this further, only a properly implemented theme inheritance is going to resolve this.  The problem is even our own themes pull from other themes, such that simply replacing the hardcoded xhtml with the dynamic theme name won't work.  Therefore, I'm changing this to a new feature request since it does work as advertised.

> Implement theme inheritance
> ---------------------------
>
>                 Key: WW-1328
>                 URL: http://issues.apache.org/struts/browse/WW-1328
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: WW 2.2.2
>            Reporter: Nick Hill
>         Assigned To: Don Brown
>             Fix For: 2.0.1
>
>
> If you look at one of the xhtml themes, for example, text.ftl, it is hard coded to use the xhtml controlfooter. This poses a problem for overridding the theme.
> Example xhtml/text.ftl:
> <#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" />
> <#include "/${parameters.templateDir}/simple/text.ftl" />
> <#include "/${parameters.templateDir}/xhtml/controlfooter.ftl" />
> Notice the controlfooter does not use ${parameters.theme} but rather is hard coded to xhtml. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira