You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/18 18:12:31 UTC

[GitHub] [incubator-superset] kgabryje commented on a change in pull request #12123: feat: Add Saved Metrics tab to metrics popover

kgabryje commented on a change in pull request #12123:
URL: https://github.com/apache/incubator-superset/pull/12123#discussion_r546003376



##########
File path: superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx
##########
@@ -276,8 +335,28 @@ export default class AdhocMetricEditPopover extends React.Component {
               </Select>
             </FormGroup>
           </Tabs.TabPane>
+          <Tabs.TabPane key={SAVED_TAB_KEY} tab="Saved">
+            <FormGroup>
+              <FormLabel>
+                <strong>Saved metric</strong>

Review comment:
       Done. I also added translations to other untranslated strings that hung around




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org