You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/15 16:22:34 UTC
[GitHub] [beam] MakarkinSAkvelon opened a new pull request, #22300: Fixed PG DeployExamples, modified "get difference" step, execution tr…
MakarkinSAkvelon opened a new pull request, #22300:
URL: https://github.com/apache/beam/pull/22300
The following flow will be applied:
Once a PR merged to master branch, this pipeline will be triggered. It executes both jobs: collect examples and deploy examples. The change between examples is controlled by "get Difference" step: it's compare previous commit with the current one (git diff --name-only ${{ github.event.before }} ${{ github.event.after }}) (assuming that all PRs are squashed to 1 commit on merge to master). Pipeline trigger was also change: Now it will execute once pull request will me merged
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] VladMatyunin commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
VladMatyunin commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185725903
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22300:
URL: https://github.com/apache/beam/pull/22300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185858907
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] VladMatyunin commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
VladMatyunin commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185735127
There is an assumption: "... all PRs are squashed to 1 commit on merge to master".
I've checked some PRs in the repository, and seems like there are all squashed before merge. Please LMK if you have concerns on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185861176
seems like this may be possible (https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] VladMatyunin commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
VladMatyunin commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185913292
> ... wait - we don't always squash commits before merging. Do you htink we could use the branch in the PR and compare against master before the merge?
The problem with this is that the PR may come from a fork and it won't be assumed as protected branch. Therefore, the secrets won't work there and the pipeline won't be able to authenticate to GCP.
I'll explore the web hook approach, thank you, Pablo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22300: Fixed [Playground] DeployExamples, modified "get difference" step, execution tr…
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22300:
URL: https://github.com/apache/beam/pull/22300#issuecomment-1185860909
... wait - we don't always squash commits before merging. Do you htink we could use the branch in the PR and compare against master before the merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org