You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/07/22 10:03:35 UTC
[GitHub] commons-lang pull request #279: Fraction debug printings
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/279
Fraction debug printings
Removed commented out debug printing from the Fraction class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #279
----
commit 8d61cab5592e239d732aaeb19418db77970fda7f
Author: Allon Mureinik <am...@redhat.com>
Date: 2017-07-22T10:02:47Z
Fraction debug printings
Removed commented out debug printing from the Fraction class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #279: Fraction debug printings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/279
---
[GitHub] commons-lang issue #279: Fraction debug printings
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/279
I think what Gary meant is that that comment is harmless, and can be used by other developers that want/need to debug the code, and see what is going on. I've used it in some projects myself, to indicate to fellow developers parts of the code that may be a bit fuzzy or complicated. I'm OK if it's kept, but OK too if others prefer to remove it (if we replace it by a comment like "Here we can see variable x" I'm OK as well).
---
[GitHub] commons-lang issue #279: Fraction debug printings
Posted by ameyjadiye <gi...@git.apache.org>.
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-lang/pull/279
debugging can be much effectively done with IDE, adding these kind of console output is discouraged.
I would recommend to use logging _logger.debug()_, but that's not the guidelines in commons.
so +1 to remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #279: Fraction debug printings
Posted by mureinik <gi...@git.apache.org>.
Github user mureinik commented on the issue:
https://github.com/apache/commons-lang/pull/279
How is this code useful? It adds nothing to the functionality, nor does it help explain the code. It seems like the original author used it while developing this class, but once it's done, I see no value in keeping it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #279: Fraction debug printings
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/279
[](https://coveralls.io/builds/12505545)
Coverage remained the same at 95.167% when pulling **8d61cab5592e239d732aaeb19418db77970fda7f on mureinik:cleanup** into **187a05b8a4db364af9d1c8ff4eb422082c30a1ff on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---