[jira] [Commented] (AIRFLOW-102) Test test_complex_template always succeeds

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394190#comment-16394190 ] 

ASF subversion and git services commented on AIRFLOW-102:
---------------------------------------------------------

Commit 76d11f24c64abb53826b1bb99fe87a6bfc317c43 in incubator-airflow's branch refs/heads/master from [~ashb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=76d11f2 ]

[AIRFLOW-102] Fix test_complex_template always succeeds

Exceptions from on_success_callback are stomped
on, meaning
test_complex_template would never fail.

Rather than follow the "success = True" pattern
(which results in the
lovely-to-track-down error message of
`AssertionError: False is not
true` I instead changed all these to have the
verify method be execute
-- meaning exceptions are propagated unchanged.

Thanks to @sekikn in
https://github.com/apache/incubator-
airflow/pull/2375 for the info to
track down what was going on.

Closes #2375

Closes #3100 from
ashb/template_tests_always_succeed


> Test test_complex_template always succeeds
> ------------------------------------------
>
>                 Key: AIRFLOW-102
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-102
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators, tests
>    Affects Versions: Airflow 1.7.1
>            Reporter: Paul Rhodes
>            Assignee: Kengo Seki
>            Priority: Trivial
>              Labels: newbie
>
> Since all exceptions generated by on_success_callback are captured, any assertion errors generated will automatically be consumed. Therefore assertions shouldn't make use of this call during test cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)