You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/12/01 12:38:00 UTC
[jira] [Commented] (CASSANDRA-16911) Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
[ https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641888#comment-17641888 ]
Stefan Miklosovic commented on CASSANDRA-16911:
-----------------------------------------------
[~paulo] if you read my second comment in this ticket with explanation for upgrades, do you think this makes sense to do in 4.2 / 5.0? We would get rid of logic around ephemeral marker files completely as it is in manifest.
One problem I see that if people jump from 4.0 to 5.0 and they do not go through 4.1 where this dual logic is introduced (marker file + flag in manifest), it will have same consequences as explained in that comment. I think this is acceptable if we document this properly.
What do you think?
> Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16911
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16911
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> While creating an ephemeral snapshot, a marker file is created at disk in a respective snapshot directory. This is not necessary anymore as we have introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag there. By putting the information if a snapshot is ephemeral or not into SnapshotManifest, we simplify and "clean up" the snapshotting process and related codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org