You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/08 20:26:27 UTC

[GitHub] [beam] y1chi commented on a change in pull request #12995: [BEAM-2914] Add portable merging window support to Python.

y1chi commented on a change in pull request #12995:
URL: https://github.com/apache/beam/pull/12995#discussion_r572347615



##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -400,6 +400,9 @@ def test_callbacks_with_exception(self):
   def test_register_finalizations(self):
     raise unittest.SkipTest("BEAM-6868")
 
+  def test_custom_merging_window(self):

Review comment:
       we may need to add this to spark_runner_test.py as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org