You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/05 20:15:20 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #3858: tls: Move pthread key destructor to libc

patacongo commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-nuttx/pull/3858#discussion_r646031567



##########
File path: include/nuttx/sched.h
##########
@@ -530,14 +530,6 @@ struct task_group_s
   FAR struct join_s *tg_jointail; /* Tail of a list of join data            */
 #endif
 
-  /* Thread local storage ***************************************************/
-
-#if CONFIG_TLS_NELEM > 0
-  tls_ndxset_t tg_tlsset;                   /* Set of TLS indexes allocated */
-

Review comment:
       I think that tg_tlsset should remain inside the group structure.  It is not accessible to user's and should be protected.  Access must be atomic and this was done with a critical section, I believe.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org