You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/28 03:32:12 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
HyukjinKwon opened a new pull request, #39252:
URL: https://github.com/apache/spark/pull/39252
### What changes were proposed in this pull request?
This PR proposes to add a parent Protobuf message for Catalog (see https://github.com/apache/spark/pull/39214#discussion_r1057439608).
### Why are the changes needed?
For better readability, and we could maintain this more easily in the future. We should redesign this part.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unittests should cover them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
URL: https://github.com/apache/spark/pull/39252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39252:
URL: https://github.com/apache/spark/pull/39252#issuecomment-1366407948
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #39252:
URL: https://github.com/apache/spark/pull/39252#discussion_r1058067646
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -70,35 +70,7 @@ message Relation {
StatDescribe describe = 102;
// Catalog API (internal-only)
Review Comment:
```suggestion
// Catalog API (experimental / unstable)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39252:
URL: https://github.com/apache/spark/pull/39252#issuecomment-1366341521
cc @zhengruifeng and @grundprinzip FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #39252:
URL: https://github.com/apache/spark/pull/39252#discussion_r1058067556
##########
connector/connect/common/src/main/protobuf/spark/connect/catalog.proto:
##########
@@ -24,6 +24,41 @@ import "spark/connect/types.proto";
option java_multiple_files = true;
option java_package = "org.apache.spark.connect.proto";
+// Catalog messages are all meant to be internal.
Review Comment:
```suggestion
// Catalog messages are marked as unstable..
```
##########
connector/connect/common/src/main/protobuf/spark/connect/catalog.proto:
##########
@@ -24,6 +24,41 @@ import "spark/connect/types.proto";
option java_multiple_files = true;
option java_package = "org.apache.spark.connect.proto";
+// Catalog messages are all meant to be internal.
Review Comment:
```suggestion
// Catalog messages are marked as unstable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org