You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2018/03/25 16:17:09 UTC

[incubator-plc4x] 02/03: - Made sure 'logback-classic' isn't included as a compile time dependency.

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git

commit 90c5f6ef9925e586e1077c15248d6478651f8813
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Sun Mar 25 18:16:24 2018 +0200

    - Made sure 'logback-classic' isn't included as a compile time dependency.
---
 plc4j/protocols/benchmarks/pom.xml              | 1 +
 plc4j/protocols/driver-bases/base/pom.xml       | 1 +
 plc4j/protocols/driver-bases/raw-socket/pom.xml | 1 +
 plc4j/protocols/driver-bases/serial/pom.xml     | 1 +
 plc4j/protocols/driver-bases/tcp/pom.xml        | 1 +
 plc4j/protocols/driver-bases/test/pom.xml       | 1 +
 plc4j/protocols/modbus/pom.xml                  | 1 +
 plc4j/protocols/s7/pom.xml                      | 5 +----
 pom.xml                                         | 5 +++++
 9 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/plc4j/protocols/benchmarks/pom.xml b/plc4j/protocols/benchmarks/pom.xml
index 7eecc58..3d0a6b4 100644
--- a/plc4j/protocols/benchmarks/pom.xml
+++ b/plc4j/protocols/benchmarks/pom.xml
@@ -45,6 +45,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>io.netty</groupId>
diff --git a/plc4j/protocols/driver-bases/base/pom.xml b/plc4j/protocols/driver-bases/base/pom.xml
index e46a855..3c54e11 100644
--- a/plc4j/protocols/driver-bases/base/pom.xml
+++ b/plc4j/protocols/driver-bases/base/pom.xml
@@ -47,6 +47,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/driver-bases/raw-socket/pom.xml b/plc4j/protocols/driver-bases/raw-socket/pom.xml
index 563176c..e24c6b9 100644
--- a/plc4j/protocols/driver-bases/raw-socket/pom.xml
+++ b/plc4j/protocols/driver-bases/raw-socket/pom.xml
@@ -58,6 +58,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/driver-bases/serial/pom.xml b/plc4j/protocols/driver-bases/serial/pom.xml
index cb70a0d..d1da021 100644
--- a/plc4j/protocols/driver-bases/serial/pom.xml
+++ b/plc4j/protocols/driver-bases/serial/pom.xml
@@ -57,6 +57,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/driver-bases/tcp/pom.xml b/plc4j/protocols/driver-bases/tcp/pom.xml
index a7b9186..be2eade 100644
--- a/plc4j/protocols/driver-bases/tcp/pom.xml
+++ b/plc4j/protocols/driver-bases/tcp/pom.xml
@@ -52,6 +52,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/driver-bases/test/pom.xml b/plc4j/protocols/driver-bases/test/pom.xml
index 1c05750..450c7fd 100644
--- a/plc4j/protocols/driver-bases/test/pom.xml
+++ b/plc4j/protocols/driver-bases/test/pom.xml
@@ -52,6 +52,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/modbus/pom.xml b/plc4j/protocols/modbus/pom.xml
index 5dc8759..4a908e5 100644
--- a/plc4j/protocols/modbus/pom.xml
+++ b/plc4j/protocols/modbus/pom.xml
@@ -75,6 +75,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
diff --git a/plc4j/protocols/s7/pom.xml b/plc4j/protocols/s7/pom.xml
index a71d552..40c5c7e 100644
--- a/plc4j/protocols/s7/pom.xml
+++ b/plc4j/protocols/s7/pom.xml
@@ -75,11 +75,8 @@
 
     <dependency>
       <groupId>ch.qos.logback</groupId>
-      <artifactId>logback-classic</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>ch.qos.logback</groupId>
       <artifactId>logback-core</artifactId>
+      <scope>test</scope>
     </dependency>
 
     <dependency>
diff --git a/pom.xml b/pom.xml
index 9c1b2f6..c16bf4e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -121,15 +121,20 @@
 
   <dependencyManagement>
     <dependencies>
+      <!--
+        Set to provided to ensure that these jars are never automatically
+        included. If required the used still can override it if it is needed. -->
       <dependency>
         <groupId>ch.qos.logback</groupId>
         <artifactId>logback-classic</artifactId>
         <version>${logback.version}</version>
+        <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>ch.qos.logback</groupId>
         <artifactId>logback-core</artifactId>
         <version>${logback.version}</version>
+        <scope>provided</scope>
       </dependency>
       <dependency>
         <groupId>com.google.code.gson</groupId>

-- 
To stop receiving notification emails like this one, please contact
cdutz@apache.org.