[GitHub] [iceberg] wypoon commented on pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox <gi...@apache.org>]

wypoon commented on pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#issuecomment-794840167


   @yyanyy thank you for your work in #2096 and #2275.
   @rdblue can you please take a look at this again and let me know your thoughts on how to proceed with this? I think that there is still a place for this work. There are two parts to this work: 
   1. `BaseTable#getSchemaForSnapshot`.
   2. Changes to Spark 2 and Spark 3 to use the schema for the snapshot when reading. These directly or indirectly call `BaseTable#getSchemaForSnapshot`.
   The first part can be changed to lookup the schema by `schema-id` from the `schemas` list now that snapshots in the `snapshot-log` have a `schema-id` with @yyanyy's work. The second part, I think, is still applicable.
   One other aspect is that I'm not competent to make changes for the other supported components such as Hive and Flink, only for Spark, but the changes for those components could be done separately and by other folks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org