You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/31 12:50:55 UTC
[GitHub] [airflow] kaxil opened a new pull request #6981: WIP:
[AIRFLOW-6413] Add config file for Mergeable Github integration
kaxil opened a new pull request #6981: WIP: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981
- [ ] Description above provides context of the change
- [ ] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6981:
[AIRFLOW-6413] Add config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981#discussion_r362221733
##########
File path: .github/mergeable.yml
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: 2
+mergeable:
+ - when: pull_request.*, pull_request_review.*
+ validate:
+ - do: title
+ # Do not merge when it is marked work in progress (WIP)
+ must_exclude:
+ regex: ^\[WIP\]
+ message: This is work in progress. Do not merge yet.
+ begins_with:
+ match: '[AIRFLOW-'
+ must_include:
+ regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\])
Review comment:
:D This was intentional as there was a recent change in Github PR template that asked users to add 4 X's `[AIRFLOW-XXXX]` for docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6981:
[AIRFLOW-6413] Add config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981#discussion_r362232878
##########
File path: .github/mergeable.yml
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: 2
+mergeable:
+ - when: pull_request.*, pull_request_review.*
+ validate:
+ - do: title
+ # Do not merge when it is marked work in progress (WIP)
+ must_exclude:
+ regex: ^\[WIP\]
+ message: This is work in progress. Do not merge yet.
+ begins_with:
+ match: '[AIRFLOW-'
+ must_include:
+ regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\])
Review comment:
That reminds you that if you have XXX in the release scripts to distinguish doc-only updates, it should be updated to support also XXXX (maybe - depends if you have in search pattern "]" ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #6981: [AIRFLOW-6413] Add
config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6981:
[AIRFLOW-6413] Add config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981#discussion_r362233156
##########
File path: .github/mergeable.yml
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: 2
+mergeable:
+ - when: pull_request.*, pull_request_review.*
+ validate:
+ - do: title
+ # Do not merge when it is marked work in progress (WIP)
+ must_exclude:
+ regex: ^\[WIP\]
+ message: This is work in progress. Do not merge yet.
+ begins_with:
+ match: '[AIRFLOW-'
+ must_include:
+ regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\])
Review comment:
BTW. I really love that people will have to manually click the checkboxes now (though initially people won't understand why mergable complains). Happened already with @michalslowikowski00 :D. But I think this is good if they ask.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6981:
[AIRFLOW-6413] Add config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981#discussion_r362221418
##########
File path: .github/mergeable.yml
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: 2
+mergeable:
+ - when: pull_request.*, pull_request_review.*
+ validate:
+ - do: title
+ # Do not merge when it is marked work in progress (WIP)
+ must_exclude:
+ regex: ^\[WIP\]
+ message: This is work in progress. Do not merge yet.
+ begins_with:
+ match: '[AIRFLOW-'
+ must_include:
+ regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\])
Review comment:
This should be `AIRFLOW-XXX` not `XXXX` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6981:
[AIRFLOW-6413] Add config file for Mergeable Github integration
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6981: [AIRFLOW-6413] Add config file for Mergeable Github integration
URL: https://github.com/apache/airflow/pull/6981#discussion_r362232878
##########
File path: .github/mergeable.yml
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: 2
+mergeable:
+ - when: pull_request.*, pull_request_review.*
+ validate:
+ - do: title
+ # Do not merge when it is marked work in progress (WIP)
+ must_exclude:
+ regex: ^\[WIP\]
+ message: This is work in progress. Do not merge yet.
+ begins_with:
+ match: '[AIRFLOW-'
+ must_include:
+ regex: ^(\[AIRFLOW-XXXX\]|\[AIRFLOW\-\d{1,4}\])
Review comment:
That reminds you that if you have XXX in the release scripts to distinguish doc-only updates, it should be updated to support also XXXX (maybe - depends if you have in search pattern "]")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services