You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/17 14:05:14 UTC

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2714: Update documentation with purpose of the "cache"

ctubbsii commented on code in PR #2714:
URL: https://github.com/apache/accumulo/pull/2714#discussion_r874861639


##########
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCacheFactory.java:
##########
@@ -26,9 +26,14 @@
 
 /**
  * A factory for {@link ZooCache} instances.
+ * <p>
+ * Implementation note: We are using this "cache" to track all the instances that have been created,

Review Comment:
   The word "cache" here is confusing since what it refers to is not an instance of any kind of cache, but we are dealing with ZooCache objects in this class. It would be better to refer to it directly,
   
   ```suggestion
    * Implementation note: We are using the instances map to track all the instances that have been created,
   ```
   
   Otherwise, these changes are good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org