You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/05/02 22:13:07 UTC
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2927
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Add option for caller to provide expression buffers for hash table
This patch doesn't change the default behaviour, but adds the plumbing
necessary for callers to avoid using HashTableContext's builtin buffers.
Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
---
M be/src/exec/hash-table-test.cc
M be/src/exec/hash-table.cc
M be/src/exec/hash-table.h
M be/src/exec/hash-table.inline.h
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-hash-join-node.cc
6 files changed, 264 insertions(+), 134 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/27/2927/1
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change.
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Patch Set 1:
Is this setting up a performance improvement?
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Patch Set 1:
Yeah I added this plumbing for a different patch that didn't work out, but it should be useful for http://gerrit.cloudera.org:8080/#/c/2896/
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Patch Set 1:
> Yeah I added this plumbing for a different patch that didn't work
> out, but it should be useful for http://gerrit.cloudera.org:8080/#/c/2896/
Now that that patch is merged, could you run some perf tests and see if this patch improves overall performance?
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) Add option for caller to provide expression buffers for hash table
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add option for caller to provide expression buffers for hash table
......................................................................
Patch Set 1:
Hmm, I think we need to reevaluate whether this is the direciton we want to go (things changed a lot between when I posted this and now). I'll abandon and talk about it offline with michael
--
To view, visit http://gerrit.cloudera.org:8080/2927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd3dbe7b7b5d6d3e8590a3474696ef58c8303e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No