You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/10/18 12:48:08 UTC

Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14739/
-----------------------------------------------------------

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-4783
    https://issues.apache.org/jira/browse/CLOUDSTACK-4783


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted


Diffs
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 
  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 0b937be 
  server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 
  server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed 

Diff: https://reviews.apache.org/r/14739/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14739/#review27188
-----------------------------------------------------------


Commit 5eb5594e8e646dbba29746c5aeb8cb8dd2a3c343 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5eb5594 ]

CLOUDSTACK-4783: Added supported for listing all templates/ISOs with showremoved = true


- ASF Subversion and Git Services


On Oct. 18, 2013, 12:17 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14739/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 12:17 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4783
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4783
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java b490ca9 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 0b937be 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 
>   server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed 
> 
> Diff: https://reviews.apache.org/r/14739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14739/#review27187
-----------------------------------------------------------


Patch fails in master.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-server: Compilation failure
[ERROR] /home/kishan/workspace/asf/incubator-cloudstack/server/src/com/cloud/api/query/vo/TemplateJoinVO.java:[85,27] error: cannot find symbol

GenericDao.REMOVED is not available in master

- Kishan Kavala


On Oct. 18, 2013, 5:47 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14739/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 5:47 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4783
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4783
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java b490ca9 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 0b937be 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 
>   server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed 
> 
> Diff: https://reviews.apache.org/r/14739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14739/#review27189
-----------------------------------------------------------


Commited to 4.2 branch

commit 5eb5594e8e646dbba29746c5aeb8cb8dd2a3c343
Author: Harikrishna Patnala <ha...@citrix.com>
Date:   Fri Oct 18 16:13:04 2013 +0530

    CLOUDSTACK-4783: Added supported for listing all templates/ISOs with showremoved = true


- Kishan Kavala


On Oct. 18, 2013, 5:47 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14739/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 5:47 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4783
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4783
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java b490ca9 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 0b937be 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 
>   server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed 
> 
> Diff: https://reviews.apache.org/r/14739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 14739: CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14739/
-----------------------------------------------------------

(Updated Oct. 18, 2013, 12:17 p.m.)


Review request for cloudstack and Kishan Kavala.


Changes
-------

added support to listIsos


Bugs: CLOUDSTACK-4783
    https://issues.apache.org/jira/browse/CLOUDSTACK-4783


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4783: Unable to see a derieved template if the parent template is deleted


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java d71db40 
  api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java b490ca9 
  api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 0b937be 
  server/src/com/cloud/api/query/QueryManagerImpl.java 6104ec0 
  server/src/com/cloud/api/query/vo/TemplateJoinVO.java bb1cfed 

Diff: https://reviews.apache.org/r/14739/diff/


Testing
-------


Thanks,

Harikrishna Patnala