You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/24 03:42:43 UTC
[GitHub] [flink] lirui-apache opened a new pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
lirui-apache opened a new pull request #14484:
URL: https://github.com/apache/flink/pull/14484
…ing RowData to Row
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix the ClassCastException issue when inserting into hive.
## Brief change log
- Copy the record when converting RowData to Row in HiveTableSink
- Add test case
## Verifying this change
Existing and added test cases
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0270bc4540b920f0748fa508f384059243a2af71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599)
* adaac76c0ae0a62ca7f156340653128a43bf7b20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750726380
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 70e5c0e7d06fccc87dbbdf1b039f1eeabd096246 (Thu Dec 24 03:44:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20722).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0270bc4540b920f0748fa508f384059243a2af71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599)
* adaac76c0ae0a62ca7f156340653128a43bf7b20 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfaae05336948967bec78b331a99c4c598f9044d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285)
* 0270bc4540b920f0748fa508f384059243a2af71 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70e5c0e7d06fccc87dbbdf1b039f1eeabd096246 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276)
* bfaae05336948967bec78b331a99c4c598f9044d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adaac76c0ae0a62ca7f156340653128a43bf7b20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645)
* af484144ed52eb8074b78710915bff0fb049dc97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af484144ed52eb8074b78710915bff0fb049dc97 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70e5c0e7d06fccc87dbbdf1b039f1eeabd096246 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276)
* bfaae05336948967bec78b331a99c4c598f9044d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfaae05336948967bec78b331a99c4c598f9044d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285)
* 0270bc4540b920f0748fa508f384059243a2af71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
}, {
"hash" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af484144ed52eb8074b78710915bff0fb049dc97 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577)
* d95bcdeacb60d70108bcb9fe880ad212e9f8a62e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adaac76c0ae0a62ca7f156340653128a43bf7b20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645)
* af484144ed52eb8074b78710915bff0fb049dc97 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14484:
URL: https://github.com/apache/flink/pull/14484#discussion_r616333752
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/MultipleInputStreamOperatorBase.java
##########
@@ -245,9 +245,9 @@ private void createAllOperators(StreamOperatorParameters<RowData> parameters) {
output = outputs[0];
} else {
if (isObjectReuseEnabled) {
Review comment:
please add some comments for this behavior, just like the comments in OperatorChain#createOutputCollector method
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -67,6 +67,43 @@ public static void setup() {
hiveCatalog.getHiveConf(), HiveShimLoader.getHiveVersion());
}
+ @Test
+ public void testMultiInputBroadcast() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src1(key string, val string)");
+ tableEnv.executeSql("create table src2(key string, val string)");
+ tableEnv.executeSql("create table dest(key string, val string)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "src1")
+ .addRow(new Object[] {"1", "val1"})
+ .addRow(new Object[] {"2", "val2"})
+ .addRow(new Object[] {"3", "val3"})
+ .commit();
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "src2")
+ .addRow(new Object[] {"3", "val4"})
+ .addRow(new Object[] {"4", "val4"})
+ .commit();
+ tableEnv.executeSql(
+ "INSERT OVERWRITE dest\n"
+ + "SELECT j.*\n"
+ + "FROM (SELECT t1.key, p1.val\n"
+ + " FROM src2 t1\n"
+ + " LEFT OUTER JOIN src1 p1\n"
+ + " ON (t1.key = p1.key)\n"
+ + " UNION ALL\n"
+ + " SELECT t2.key, p2.val\n"
+ + " FROM src2 t2\n"
+ + " LEFT OUTER JOIN src1 p2\n"
+ + " ON (t2.key = p2.key)) j")
+ .await();
Review comment:
do we need to check the result ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14484:
URL: https://github.com/apache/flink/pull/14484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-823021103
@godfreyhe Thanks for your comments. PR updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750726380
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d95bcdeacb60d70108bcb9fe880ad212e9f8a62e (Sat Aug 28 11:16:24 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
}, {
"hash" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16850",
"triggerID" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af484144ed52eb8074b78710915bff0fb049dc97 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577)
* d95bcdeacb60d70108bcb9fe880ad212e9f8a62e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
}, {
"hash" : "af484144ed52eb8074b78710915bff0fb049dc97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16577",
"triggerID" : "af484144ed52eb8074b78710915bff0fb049dc97",
"triggerType" : "PUSH"
}, {
"hash" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16850",
"triggerID" : "d95bcdeacb60d70108bcb9fe880ad212e9f8a62e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d95bcdeacb60d70108bcb9fe880ad212e9f8a62e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70e5c0e7d06fccc87dbbdf1b039f1eeabd096246 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0270bc4540b920f0748fa508f384059243a2af71 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
}, {
"hash" : "0270bc4540b920f0748fa508f384059243a2af71",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12599",
"triggerID" : "0270bc4540b920f0748fa508f384059243a2af71",
"triggerType" : "PUSH"
}, {
"hash" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645",
"triggerID" : "adaac76c0ae0a62ca7f156340653128a43bf7b20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* adaac76c0ae0a62ca7f156340653128a43bf7b20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12645)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
}, {
"hash" : "bfaae05336948967bec78b331a99c4c598f9044d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285",
"triggerID" : "bfaae05336948967bec78b331a99c4c598f9044d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfaae05336948967bec78b331a99c4c598f9044d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11285)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-750730068
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276",
"triggerID" : "70e5c0e7d06fccc87dbbdf1b039f1eeabd096246",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70e5c0e7d06fccc87dbbdf1b039f1eeabd096246 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14484: [FLINK-20722][hive] HiveTableSink should copy the record when convert…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14484:
URL: https://github.com/apache/flink/pull/14484#issuecomment-751154305
Hi @godfreyhe , could you help review this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org