You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/11/22 19:25:23 UTC

[GitHub] [gobblin] umustafi opened a new pull request #3434: My sql connector forward only iteration

umustafi opened a new pull request #3434:
URL: https://github.com/apache/gobblin/pull/3434

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1581

### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
after sql-connector was bumped, exception results from ResultSet.first() being called because it iterates in backward direction of set
also works to change every statement to execute to be scrolled in either direction:

_PreparedStatement pstmt = this.conn.prepareStatement(sql, ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_UPDATABLE);_

### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
It does not add unit tests but I've manually tested with a snapshot that it works.

### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] umustafi closed pull request #3434: My sql connector forward only iteration

Posted by GitBox <gi...@apache.org>.

umustafi closed pull request #3434:
URL: https://github.com/apache/gobblin/pull/3434


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org