You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2023/09/15 07:14:38 UTC

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #28432: Support oracle create view parse

strongduanmu commented on code in PR #28432:
URL: https://github.com/apache/shardingsphere/pull/28432#discussion_r1326894079


##########
parser/sql/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/type/OracleDDLStatementVisitor.java:
##########
@@ -301,6 +304,15 @@
  */
 public final class OracleDDLStatementVisitor extends OracleStatementVisitor implements DDLStatementVisitor {
     
+    @Override
+    public ASTNode visitCreateView(final CreateViewContext ctx) {
+        OracleCreateViewStatement result = new OracleCreateViewStatement();
+        result.setView((SimpleTableSegment) visit(ctx.viewName()));
+        result.setSelect((SelectStatement) new OracleDMLStatementVisitor().visit(ctx.select()));

Review Comment:
   Can you add parameter in OracleDMLStatementVisitor to OracleDDLStatementVisitor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org