Re: [I] Make the "Invalid JSON" validation warning on the Edit Variable form more prominent (and block/guard Save) [airflow]

["eddiesr93 (via GitHub)" <gi...@apache.org>]

eddiesr93 commented on issue #68262:
URL: https://github.com/apache/airflow/issues/68262#issuecomment-5024496993

   This looks resolved by #68268 (merged 2026-06-22). That PR did not use a closing keyword, which is why this issue stayed open.
   
   Against the three proposals in the description:
   
   1. **Prominent inline error state** — shipped. The invalid-JSON feedback now renders through the shared `Alert` component directly beneath the value field.
   2. **Blocking Save** — deliberately not shipped. The stated intent of #68268 was to "keep the invalid JSON feedback as a visible warning instead of a blocking validation error", and `VariableForm.test.tsx` pins that behaviour: Jinja templates (`{{ var.value.x }}`) and bracket-prefixed plain strings (`[DRAFT] ...`) are not valid JSON but are legitimate variable values, so Save stays enabled for them.
   3. **Pointing at the parse error location** — not implemented; the message is still a fixed string.
   
   So the visibility half of this request has shipped, and the Save-guard half was closed off by design. Item 3 is the only part still open, if it is still wanted.
   
   ---
   Drafted-by: Claude Code (Opus 4.8) (no human review before posting)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org