You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/14 02:27:57 UTC
[GitHub] [helix] mgao0 opened a new pull request #952: Distributed lock
mgao0 opened a new pull request #952: Distributed lock
URL: https://github.com/apache/helix/pull/952
- [ ] Issues
My PR addresses the following Helix issues and references them in the PR description:
#672
- [ ] Description
1. Non blocking lock. We will reserve the capability to extend to a blocking lock in the future, meaning that we could provide the boolean parameter in API for either nonblocking or blocking.
2. Timeout support. The client need to input the timeout when it tries to acquire the lock. After timeout, if no other client tries to get the lock, the client can still keep the lock, if other client tries to acquire the lock, and finds the previous client already timeout, the previous client will be forced to release the lock.
3. Lock message support. The client can input the reason for the lock (a string) when it tries to acquire the lock, and future lock operation, when fails, will get the message for the current lock.
4. Java API support.
5. No notification support. When a client loses its lock after timeout or during SRE maintenance work, there is no notification sent out to it.
- [ ] Tests
The following tests are written for this issue:
TestZKHelixNonblockingLock
- [ ] Commits
My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
- [ ] Code Quality
My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #952: Distributed lock
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #952: Distributed lock
URL: https://github.com/apache/helix/pull/952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org