You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@netbeans.apache.org by Philip Durbin <ph...@gmail.com> on 2019/01/23 22:30:37 UTC
Does JaCoCo 0.8.2 break NetBeans code coverage?
Please see https://github.com/IQSS/dataverse/issues/5483 and
https://github.com/jacoco/jacoco/issues/772 for details but downgrading
to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else
observed this problem? Is there a ticket tracking this?
Thanks!
Phil
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Emilian Bold <em...@gmail.com>.
First time I hear about it. Since the comment mentions a simple XML change
perhaps we can do a PR?
--emi
On Thu, 24 Jan 2019 at 00:39, Philip Durbin <ph...@gmail.com> wrote:
> Please see https://github.com/IQSS/dataverse/issues/5483 and
> https://github.com/jacoco/jacoco/issues/772 for details but downgrading
> to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else
> observed this problem? Is there a ticket tracking this?
>
> Thanks!
>
> Phil
>
--
--emi
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Philip Durbin <ph...@gmail.com>.
Pasting my comment on https://github.com/jacoco/jacoco/issues/772
@emilianbold yes, @samuel-barbosa was also using NetBeans 8.2. Thank you
for the insight on the code. It looks like the fix (making NetBeans less
strict) was made at
https://github.com/apache/incubator-netbeans/commit/399b124dcc6d2eeeee938447174d37f41d1c56d9#diff-1cc461bde39d5cd90860e714737a0b60
for NetBeans 9.0 but had more to do with legal issues (
https://issues.apache.org/jira/browse/NETBEANS-853 ) than any breakage.
On Sun, Jan 27, 2019 at 1:44 AM Emilian Bold <em...@gmail.com> wrote:
> Pasting my comment on https://github.com/jacoco/jacoco/issues/772
>
> 'd like to remark that from my tests (and looking at the source code)
> this problem only happens under NetBeans 8.2! This does not happen
> under any Apache NetBeans version.
>
> Under NetBeans 8.2 this happens due to the way the DTD was obtained.
> If you look at
> http://hg.netbeans.org/main-golden/file/tip/maven.coverage/src/org/netbeans/modules/maven/coverage/MavenCoverageProvider.java
> you see a check publicId.equals("-//JACOCO//DTD Report 1.0//EN"). So
> when you moved to `DTD Report 1.1` it broke NetBeans 8.2 parsing.
> That's all.
>
> --emi
>
> On Sun, Jan 27, 2019 at 8:38 AM Emilian Bold <em...@gmail.com>
> wrote:
> >
> > Philip, did you even test this with *any* Apache NetBeans version.
> > This bug only seems to happen in NetBeans 8.2.
> >
> > --emi
> >
> > http://coolbeans.xyz/ - CoolBeans: An IDE for Java, JavaEE, PHP and
> more!
> >
> >
> > On Sat, Jan 26, 2019 at 10:14 PM Philip Durbin <ph...@gmail.com>
> wrote:
> > >
> > > Ok, I created an issue: JaCoCo 0.8.2 breaks code coverage integration
> - https://issues.apache.org/jira/browse/NETBEANS-1997
> > >
> > > I've never worked on the NetBeans code base so I don't plan to attempt
> to provide a pull request unless someone out there can provide a little
> guidance.
> > >
> > > Thanks,
> > >
> > > Phil
> > >
> > > On Wed, Jan 23, 2019 at 5:41 PM Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
> > >>
> > >> The reason for the problem is explained in the links you reference,
> would indeed be great if you'd file an issue (and ideally make an attempt
> at providing a pull request for it):
> > >>
> > >>> AFAIK NetBeans integration reads XML Report, which was intentionally
> changed in version 0.8.2 in a perfectly valid way by addition of new
> attribute - see #702. NetBeans integration must be fixed accordingly and
> ideally be less strict to cope with such updates in future. This problem
> should reported to developers of NetBeans integration
> > >>
> > >>
> > >> Thanks,
> > >>
> > >> Gj
> > >>
> > >> On Wed, Jan 23, 2019 at 11:39 PM Philip Durbin <
> philipdurbin@gmail.com> wrote:
> > >>>
> > >>> Please see https://github.com/IQSS/dataverse/issues/5483 and
> https://github.com/jacoco/jacoco/issues/772 for details but downgrading
> to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else
> observed this problem? Is there a ticket tracking this?
> > >>>
> > >>> Thanks!
> > >>>
> > >>> Phil
>
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Emilian Bold <em...@gmail.com>.
Pasting my comment on https://github.com/jacoco/jacoco/issues/772
'd like to remark that from my tests (and looking at the source code)
this problem only happens under NetBeans 8.2! This does not happen
under any Apache NetBeans version.
Under NetBeans 8.2 this happens due to the way the DTD was obtained.
If you look at http://hg.netbeans.org/main-golden/file/tip/maven.coverage/src/org/netbeans/modules/maven/coverage/MavenCoverageProvider.java
you see a check publicId.equals("-//JACOCO//DTD Report 1.0//EN"). So
when you moved to `DTD Report 1.1` it broke NetBeans 8.2 parsing.
That's all.
--emi
On Sun, Jan 27, 2019 at 8:38 AM Emilian Bold <em...@gmail.com> wrote:
>
> Philip, did you even test this with *any* Apache NetBeans version.
> This bug only seems to happen in NetBeans 8.2.
>
> --emi
>
> http://coolbeans.xyz/ - CoolBeans: An IDE for Java, JavaEE, PHP and more!
>
>
> On Sat, Jan 26, 2019 at 10:14 PM Philip Durbin <ph...@gmail.com> wrote:
> >
> > Ok, I created an issue: JaCoCo 0.8.2 breaks code coverage integration - https://issues.apache.org/jira/browse/NETBEANS-1997
> >
> > I've never worked on the NetBeans code base so I don't plan to attempt to provide a pull request unless someone out there can provide a little guidance.
> >
> > Thanks,
> >
> > Phil
> >
> > On Wed, Jan 23, 2019 at 5:41 PM Geertjan Wielenga <ge...@googlemail.com> wrote:
> >>
> >> The reason for the problem is explained in the links you reference, would indeed be great if you'd file an issue (and ideally make an attempt at providing a pull request for it):
> >>
> >>> AFAIK NetBeans integration reads XML Report, which was intentionally changed in version 0.8.2 in a perfectly valid way by addition of new attribute - see #702. NetBeans integration must be fixed accordingly and ideally be less strict to cope with such updates in future. This problem should reported to developers of NetBeans integration
> >>
> >>
> >> Thanks,
> >>
> >> Gj
> >>
> >> On Wed, Jan 23, 2019 at 11:39 PM Philip Durbin <ph...@gmail.com> wrote:
> >>>
> >>> Please see https://github.com/IQSS/dataverse/issues/5483 and https://github.com/jacoco/jacoco/issues/772 for details but downgrading to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else observed this problem? Is there a ticket tracking this?
> >>>
> >>> Thanks!
> >>>
> >>> Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@netbeans.apache.org
For additional commands, e-mail: users-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Emilian Bold <em...@gmail.com>.
Philip, did you even test this with *any* Apache NetBeans version.
This bug only seems to happen in NetBeans 8.2.
--emi
http://coolbeans.xyz/ - CoolBeans: An IDE for Java, JavaEE, PHP and more!
On Sat, Jan 26, 2019 at 10:14 PM Philip Durbin <ph...@gmail.com> wrote:
>
> Ok, I created an issue: JaCoCo 0.8.2 breaks code coverage integration - https://issues.apache.org/jira/browse/NETBEANS-1997
>
> I've never worked on the NetBeans code base so I don't plan to attempt to provide a pull request unless someone out there can provide a little guidance.
>
> Thanks,
>
> Phil
>
> On Wed, Jan 23, 2019 at 5:41 PM Geertjan Wielenga <ge...@googlemail.com> wrote:
>>
>> The reason for the problem is explained in the links you reference, would indeed be great if you'd file an issue (and ideally make an attempt at providing a pull request for it):
>>
>>> AFAIK NetBeans integration reads XML Report, which was intentionally changed in version 0.8.2 in a perfectly valid way by addition of new attribute - see #702. NetBeans integration must be fixed accordingly and ideally be less strict to cope with such updates in future. This problem should reported to developers of NetBeans integration
>>
>>
>> Thanks,
>>
>> Gj
>>
>> On Wed, Jan 23, 2019 at 11:39 PM Philip Durbin <ph...@gmail.com> wrote:
>>>
>>> Please see https://github.com/IQSS/dataverse/issues/5483 and https://github.com/jacoco/jacoco/issues/772 for details but downgrading to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else observed this problem? Is there a ticket tracking this?
>>>
>>> Thanks!
>>>
>>> Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@netbeans.apache.org
For additional commands, e-mail: users-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Philip Durbin <ph...@gmail.com>.
Ok, I created an issue: JaCoCo 0.8.2 breaks code coverage integration -
https://issues.apache.org/jira/browse/NETBEANS-1997
I've never worked on the NetBeans code base so I don't plan to attempt to
provide a pull request unless someone out there can provide a little
guidance.
Thanks,
Phil
On Wed, Jan 23, 2019 at 5:41 PM Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> The reason for the problem is explained in the links you reference, would
> indeed be great if you'd file an issue (and ideally make an attempt at
> providing a pull request for it):
>
> AFAIK NetBeans integration reads XML Report, which was intentionally
>> changed in version 0.8.2 in a perfectly valid way by addition of new
>> attribute - see #702 <https://github.com/jacoco/jacoco/pull/702>.
>> NetBeans integration must be fixed accordingly and ideally be less strict
>> to cope with such updates in future. This problem should reported to
>> developers of NetBeans integration
>>
>
> Thanks,
>
> Gj
>
> On Wed, Jan 23, 2019 at 11:39 PM Philip Durbin <ph...@gmail.com>
> wrote:
>
>> Please see https://github.com/IQSS/dataverse/issues/5483 and
>> https://github.com/jacoco/jacoco/issues/772 for details but downgrading
>> to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else
>> observed this problem? Is there a ticket tracking this?
>>
>> Thanks!
>>
>> Phil
>>
>
Re: Does JaCoCo 0.8.2 break NetBeans code coverage?
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
The reason for the problem is explained in the links you reference, would
indeed be great if you'd file an issue (and ideally make an attempt at
providing a pull request for it):
AFAIK NetBeans integration reads XML Report, which was intentionally
> changed in version 0.8.2 in a perfectly valid way by addition of new
> attribute - see #702 <https://github.com/jacoco/jacoco/pull/702>.
> NetBeans integration must be fixed accordingly and ideally be less strict
> to cope with such updates in future. This problem should reported to
> developers of NetBeans integration
>
Thanks,
Gj
On Wed, Jan 23, 2019 at 11:39 PM Philip Durbin <ph...@gmail.com>
wrote:
> Please see https://github.com/IQSS/dataverse/issues/5483 and
> https://github.com/jacoco/jacoco/issues/772 for details but downgrading
> to JaCoCo 0.8.1 seems to get code coverage working again. Has anyone else
> observed this problem? Is there a ticket tracking this?
>
> Thanks!
>
> Phil
>