You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/10/17 11:19:10 UTC
git commit: Add an explanation why SerializableChecker is run after
failed serialization.
Updated Branches:
refs/heads/master 48350b07f -> 9ed74a4e2
Add an explanation why SerializableChecker is run after failed serialization.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9ed74a4e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9ed74a4e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9ed74a4e
Branch: refs/heads/master
Commit: 9ed74a4e21df8dff0398439a8c6e612f20d729df
Parents: 48350b0
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Wed Oct 17 11:18:24 2012 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Oct 17 11:18:24 2012 +0200
----------------------------------------------------------------------
.../wicket/serialize/java/JavaSerializer.java | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/9ed74a4e/wicket-core/src/main/java/org/apache/wicket/serialize/java/JavaSerializer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/serialize/java/JavaSerializer.java b/wicket-core/src/main/java/org/apache/wicket/serialize/java/JavaSerializer.java
index 44dae8b..4096654 100644
--- a/wicket-core/src/main/java/org/apache/wicket/serialize/java/JavaSerializer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/serialize/java/JavaSerializer.java
@@ -233,7 +233,12 @@ public class JavaSerializer implements ISerializer
}
/**
* Write objects to the wrapped output stream and log a meaningful message for serialization
- * problems
+ * problems.
+ *
+ * <p>
+ * Note: the checking functionality is used only if the serialization fails with NotSerializableException.
+ * This is done so to save some CPU time to make the checks for no reason.
+ * </p>
*/
private static class SerializationCheckerObjectOutputStream extends ObjectOutputStream
{