You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/11/19 10:42:13 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2279: build/cmake/DefineOptions.cmake: Fixed the logic of BUILD_SHARED_LIBS
emmenlau opened a new pull request #2279:
URL: https://github.com/apache/thrift/pull/2279
Currently the logic of the `CMAKE_DEPENDENT_OPTION` for `BUILD_SHARED_LIBS` does not work correctly. For this setting in particular, its better to use a standard cmake option, and set the default corresponding to the individual platforms (Windows OFF, other platforms ON).
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] zeshuai007 merged pull request #2279: build/cmake/DefineOptions.cmake: Fixed the logic of BUILD_SHARED_LIBS
Posted by GitBox <gi...@apache.org>.
zeshuai007 merged pull request #2279:
URL: https://github.com/apache/thrift/pull/2279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2279: build/cmake/DefineOptions.cmake: Fixed the logic of BUILD_SHARED_LIBS
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2279:
URL: https://github.com/apache/thrift/pull/2279#issuecomment-734192298
The Travis CI build errors are unrelated, so this should be ready for merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org