[GitHub] [apisix] Firstsawyou commented on a change in pull request #4368: feat: upgrade protobuf to 0.3.2

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #4368:
URL: https://github.com/apache/apisix/pull/4368#discussion_r644673459



##########
File path: apisix/plugins/grpc-transcode/proto.lua
##########
@@ -43,7 +43,7 @@ local function create_proto_obj(proto_id)
     end
 
     local _p  = protoc.new()
-    local res = _p:load(content)
+    local res = _p:load(content, "filename for loaded") -- https://github.com/starwing/lua-protobuf/commit/89faac205585360d800472c62752d5b532d7ce9e

Review comment:
       ```suggestion
       -- https://github.com/starwing/lua-protobuf/commit/89faac205585360d800472c62752d5b532d7ce9e
       local res = _p:load(content, "filename for loaded") 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org