[jira] [Commented] (CASSANDRA-3929) Support row size limits

["Fabien Rousseau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510583#comment-13510583 ] 

Fabien Rousseau commented on CASSANDRA-3929:
--------------------------------------------

Hum, the current patch works if no deletes are done...

Let's have an example with deletes :
Suppose that we want to keep 3 columns, and have standard comparator.
Let's insert 4 column names : E, F, G, H
Then flush (on the SSTable, we will have : E, F, G, tombstone(H) ).
Let's insert another 4 column names : A, B, C, D
Then delete column B.
Then flush (on the SSTable, we will have : A, tombstone(B), C, tombstone(D) )

With the current patch (which excludes tombstones in the count on the read path) :
reading the first 3 columns would return : A,C,E
By including the tombstones in the count in the read path :
reading the first 3 columns would return : A,C

I think returning A,C,E is incorrect because last inserted columns where A,C,D.

So, to support delete, there is also something to do on the read path (include tombstones in columns count, so it never goes after "maxColumns").

I propose the patch 3929_e.txt.



                
> Support row size limits
> -----------------------
>
>                 Key: CASSANDRA-3929
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3929
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Dave Brosius
>            Priority: Minor
>              Labels: ponies
>             Fix For: 1.3
>
>         Attachments: 3929_b.txt, 3929_c.txt, 3929_d.txt, 3929_e.txt, 3929.txt
>
>
> We currently support expiring columns by time-to-live; we've also had requests for keeping the most recent N columns in a row.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira