You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/02/06 05:27:02 UTC
Review Request: Update Boost to 1.53.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16243
-----------------------------------------------------------
Can you upload the tar.gz file?
I'd like to look inside it, and reviewboard is not playing nicely.
In particular, I'd like to make sure we properly document how we've been "stripping" these to be header-only, to make future upgrades easier.
- Ben Mahler
On Feb. 6, 2013, 4:26 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Feb. 21, 2013, 7:21 p.m., Ben Mahler wrote:
> > Thanks for figuring out the bcp process!
> >
> > A few questions:
> > 1. It looks like the find operation will include boost files as well, is bcp smart enough to ignore those?
> > 2. Is 'rm libs' sufficient? It looks like you would need 'rm -r libs'?
> > 3. Why is libs produced by bcp?
> >
> > I have some revisions to the README, rather than going back and forth, I just included the contents below
> > Some trailing whitespace cleanup, and other changes.
> >
> >
> >
> >
> >
> >
> > README for the mesos third party boost distribution.
> >
> > We use the boost bcp utility to bundle only the minimum subset of boost headers
> > used by mesos.
> > See: http://www.boost.org/doc/libs/1_53_0/tools/bcp/doc/html/index.html
> >
> > Instructions for upgrading boost. (Based on boost 1.53.0)
> > -------------------------------------------------------------------------------
> > 1. Download a tarball of the latest version of boost.
> > e.g. boost_1_53_0.tar.gz
> >
> > 2. Uncompress boost and build bcp.
> > $ tar -zxvf boost_1_53_0.tar.gz
> > $ cd boost_1_53_0
> > $ ./bootstrap.sh
> > $ ./b2 tools/bcp
> >
> > 3. Get list of all C++ source files in Mesos.
> > $ find </path/to/mesos> -name "*.cpp" -o -name "*.hpp" > files.txt
> >
> > 4. Scan the source files using bcp to produce a subset of the headers.
> > $ mkdir ../boost-1.53.0
> > $ cat files.txt | xargs -I {} ./dist/bin/bcp --scan --boost=./ {} ../boost-1.53.0
> >
> > 5. Inspect contents of extracted headers and remove unnecessary lib files.
> > $ cd ../boost-1.53.0
> > $ rm libs
> >
> > 6. Update this README if needed, and copy this into boost-1.53.0 directory.
> > $ cp </path/to/README> .
> >
> > 7. Compress Boost directory and bundle it into mess.
> > $ cd ..
> > $ GZIP=--best tar -zcf boost-1.53.0.tar.gz boost-1.53.0
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/libprocess/third_party/
> >
> > 8. Update third_party/versions.am and third_party/libprocess/versions.am.
> >
> > 9. Verify correctness.
> > $ make clean check
> >
>
> Vinod Kone wrote:
> This README is great. Thank you guys!
>
> How hard is it to just script this?
This is fantastic David! Scripting it would be great, but this is already so much better than what we had! If we scripted it you could toss it in 'tools'. Also, pay the good people at Boost and Mesos some respect and capitalize Boost and Mesos everywhere (except in code/shell snippets of course). ;) Thank you!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16871
-----------------------------------------------------------
On Feb. 21, 2013, 5:06 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 5:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 21, 2013, 7:21 p.m., Ben Mahler wrote:
> > Thanks for figuring out the bcp process!
> >
> > A few questions:
> > 1. It looks like the find operation will include boost files as well, is bcp smart enough to ignore those?
> > 2. Is 'rm libs' sufficient? It looks like you would need 'rm -r libs'?
> > 3. Why is libs produced by bcp?
> >
> > I have some revisions to the README, rather than going back and forth, I just included the contents below
> > Some trailing whitespace cleanup, and other changes.
> >
> >
> >
> >
> >
> >
> > README for the mesos third party boost distribution.
> >
> > We use the boost bcp utility to bundle only the minimum subset of boost headers
> > used by mesos.
> > See: http://www.boost.org/doc/libs/1_53_0/tools/bcp/doc/html/index.html
> >
> > Instructions for upgrading boost. (Based on boost 1.53.0)
> > -------------------------------------------------------------------------------
> > 1. Download a tarball of the latest version of boost.
> > e.g. boost_1_53_0.tar.gz
> >
> > 2. Uncompress boost and build bcp.
> > $ tar -zxvf boost_1_53_0.tar.gz
> > $ cd boost_1_53_0
> > $ ./bootstrap.sh
> > $ ./b2 tools/bcp
> >
> > 3. Get list of all C++ source files in Mesos.
> > $ find </path/to/mesos> -name "*.cpp" -o -name "*.hpp" > files.txt
> >
> > 4. Scan the source files using bcp to produce a subset of the headers.
> > $ mkdir ../boost-1.53.0
> > $ cat files.txt | xargs -I {} ./dist/bin/bcp --scan --boost=./ {} ../boost-1.53.0
> >
> > 5. Inspect contents of extracted headers and remove unnecessary lib files.
> > $ cd ../boost-1.53.0
> > $ rm libs
> >
> > 6. Update this README if needed, and copy this into boost-1.53.0 directory.
> > $ cp </path/to/README> .
> >
> > 7. Compress Boost directory and bundle it into mess.
> > $ cd ..
> > $ GZIP=--best tar -zcf boost-1.53.0.tar.gz boost-1.53.0
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/libprocess/third_party/
> >
> > 8. Update third_party/versions.am and third_party/libprocess/versions.am.
> >
> > 9. Verify correctness.
> > $ make clean check
> >
This README is great. Thank you guys!
How hard is it to just script this?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16871
-----------------------------------------------------------
On Feb. 21, 2013, 5:06 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 5:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
> On Feb. 21, 2013, 7:21 p.m., Ben Mahler wrote:
> > Thanks for figuring out the bcp process!
> >
> > A few questions:
> > 1. It looks like the find operation will include boost files as well, is bcp smart enough to ignore those?
> > 2. Is 'rm libs' sufficient? It looks like you would need 'rm -r libs'?
> > 3. Why is libs produced by bcp?
> >
> > I have some revisions to the README, rather than going back and forth, I just included the contents below
> > Some trailing whitespace cleanup, and other changes.
> >
> >
> >
> >
> >
> >
> > README for the mesos third party boost distribution.
> >
> > We use the boost bcp utility to bundle only the minimum subset of boost headers
> > used by mesos.
> > See: http://www.boost.org/doc/libs/1_53_0/tools/bcp/doc/html/index.html
> >
> > Instructions for upgrading boost. (Based on boost 1.53.0)
> > -------------------------------------------------------------------------------
> > 1. Download a tarball of the latest version of boost.
> > e.g. boost_1_53_0.tar.gz
> >
> > 2. Uncompress boost and build bcp.
> > $ tar -zxvf boost_1_53_0.tar.gz
> > $ cd boost_1_53_0
> > $ ./bootstrap.sh
> > $ ./b2 tools/bcp
> >
> > 3. Get list of all C++ source files in Mesos.
> > $ find </path/to/mesos> -name "*.cpp" -o -name "*.hpp" > files.txt
> >
> > 4. Scan the source files using bcp to produce a subset of the headers.
> > $ mkdir ../boost-1.53.0
> > $ cat files.txt | xargs -I {} ./dist/bin/bcp --scan --boost=./ {} ../boost-1.53.0
> >
> > 5. Inspect contents of extracted headers and remove unnecessary lib files.
> > $ cd ../boost-1.53.0
> > $ rm libs
> >
> > 6. Update this README if needed, and copy this into boost-1.53.0 directory.
> > $ cp </path/to/README> .
> >
> > 7. Compress Boost directory and bundle it into mess.
> > $ cd ..
> > $ GZIP=--best tar -zcf boost-1.53.0.tar.gz boost-1.53.0
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/
> > $ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/libprocess/third_party/
> >
> > 8. Update third_party/versions.am and third_party/libprocess/versions.am.
> >
> > 9. Verify correctness.
> > $ make clean check
> >
>
> Vinod Kone wrote:
> This README is great. Thank you guys!
>
> How hard is it to just script this?
>
> Benjamin Hindman wrote:
> This is fantastic David! Scripting it would be great, but this is already so much better than what we had! If we scripted it you could toss it in 'tools'. Also, pay the good people at Boost and Mesos some respect and capitalize Boost and Mesos everywhere (except in code/shell snippets of course). ;) Thank you!
Thanks for the cleanup, awesome.
1. It looks like the find operation will include boost files as well, is bcp smart enough to ignore those?
A: Yes, bcp is Boost aware and ignores files that are part of the Boost.
2. Is 'rm libs' sufficient? It looks like you would need 'rm -r libs'?
A: Yes, rm -r is required. I'll update.
3. Why is libs produced by bcp?
A: BCP's dependency resolution is somewhat opportunistic in what it thinks is necessary. With 1.53.0, a few of the smart_ptr headers get included as part of this resolution which then pulls in sp_collector.cpp and sp_debug_hooks.cpp into the libs/ which are only necessary if you're using smart_ptrs and want to run them in debugging mode which is enabled at compile time by setting #define BOOST_SP_ENABLE_DEBUG_HOOKS. Since Mesos appears to require none of this, I went ahead with removing these two files which leaves libs/ empty.
4. How hard is it to just script this?
A: Seemingly, pretty easy. Would just need to pass in the path to the Boost tarball and the Mesos src dir and run these commands with a few variable substitutions. I haven't done it, but I'll put one together out of band from this change.
I'll also clean up the capitalization
I'll update Ben's revision to include the rm fix and capitalization cleanup and repost the patch.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16871
-----------------------------------------------------------
On Feb. 21, 2013, 5:06 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 5:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16871
-----------------------------------------------------------
Thanks for figuring out the bcp process!
A few questions:
1. It looks like the find operation will include boost files as well, is bcp smart enough to ignore those?
2. Is 'rm libs' sufficient? It looks like you would need 'rm -r libs'?
3. Why is libs produced by bcp?
I have some revisions to the README, rather than going back and forth, I just included the contents below
Some trailing whitespace cleanup, and other changes.
README for the mesos third party boost distribution.
We use the boost bcp utility to bundle only the minimum subset of boost headers
used by mesos.
See: http://www.boost.org/doc/libs/1_53_0/tools/bcp/doc/html/index.html
Instructions for upgrading boost. (Based on boost 1.53.0)
-------------------------------------------------------------------------------
1. Download a tarball of the latest version of boost.
e.g. boost_1_53_0.tar.gz
2. Uncompress boost and build bcp.
$ tar -zxvf boost_1_53_0.tar.gz
$ cd boost_1_53_0
$ ./bootstrap.sh
$ ./b2 tools/bcp
3. Get list of all C++ source files in Mesos.
$ find </path/to/mesos> -name "*.cpp" -o -name "*.hpp" > files.txt
4. Scan the source files using bcp to produce a subset of the headers.
$ mkdir ../boost-1.53.0
$ cat files.txt | xargs -I {} ./dist/bin/bcp --scan --boost=./ {} ../boost-1.53.0
5. Inspect contents of extracted headers and remove unnecessary lib files.
$ cd ../boost-1.53.0
$ rm libs
6. Update this README if needed, and copy this into boost-1.53.0 directory.
$ cp </path/to/README> .
7. Compress Boost directory and bundle it into mess.
$ cd ..
$ GZIP=--best tar -zcf boost-1.53.0.tar.gz boost-1.53.0
$ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/
$ cp boost-1.53.0.tar.gz </path/to/mesos>/third_party/libprocess/third_party/
8. Update third_party/versions.am and third_party/libprocess/versions.am.
9. Verify correctness.
$ make clean check
- Ben Mahler
On Feb. 21, 2013, 5:06 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2013, 5:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review17046
-----------------------------------------------------------
Ship it!
Ship it from me, I'm not too concerned with scripting the update as it requires changing makefiles and potentially the README as well. Doing so by hand seems not too cumbersome given how infrequent boost upgrades are.
- Ben Mahler
On Feb. 25, 2013, 3:55 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 3:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review17047
-----------------------------------------------------------
Ship it!
Let's get this committed.
- Benjamin Hindman
On Feb. 25, 2013, 3:55 p.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 3:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 3:55 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 3:55 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Attaching updated Boost tarball.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 3:54 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Updated README based on comments.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs (updated)
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 5:06 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Updated Diff to reflect changes to boost-1.53.0.tar.gz.
Old 1.51.0 binary size: 6.86998 megabytes.
New 1.53.0 binary size: 0.924499 megabytes.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs (updated)
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 4:56 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 4:55 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Upload of boost-1.53.0.tar.gz that was extracted using BCP and includes README. Will attach binary diff.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 21, 2013, 4:53 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16257
-----------------------------------------------------------
As discussed, let's add documentation to our README inside boost that outlines the exact steps taken to trim the fat off of the boost distribution.
I should have done when I upgraded this last time.
The goal is to make it much easier on the next person who has to do a boost upgrade.
I think the ideal solution for us would be to use bcp to scan our source, but that's a bit more involved so feel free to just add a TODO for that (inside our boost README).
- Ben Mahler
On Feb. 7, 2013, 2:18 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2013, 2:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Update Boost to 1.53.0
Posted by David Mackey <td...@booleanhaiku.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/
-----------------------------------------------------------
(Updated Feb. 7, 2013, 2:18 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Added boost-1.53.0.tar.gz attachment.
Description
-------
- Add header-only boost version 1.53.0 libraries
- Fix Boost-related build issues for MESOS-271
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am b974985
third_party/versions.am 09e1b57
Diff: https://reviews.apache.org/r/9316/diff/
Testing
-------
make check
Thanks,
David Mackey
Re: Review Request: Update Boost to 1.53.0
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9316/#review16192
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 6, 2013, 4:26 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9316/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> - Add header-only boost version 1.53.0 libraries
> - Fix Boost-related build issues for MESOS-271
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/boost-1.51.0.tar.gz e461b8a426859720d1b867ca981ba8131e8ebe70
> third_party/libprocess/third_party/boost-1.53.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am b974985
> third_party/versions.am 09e1b57
>
> Diff: https://reviews.apache.org/r/9316/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> David Mackey
>
>