[GitHub] [cloudstack] wido commented on pull request #6164: Mount disabled storage pool on host reboot

[GitBox <gi...@apache.org>]

wido commented on PR #6164:
URL: https://github.com/apache/cloudstack/pull/6164#issuecomment-1088634309

   I noticed this PR a bit late. Great PR and good catch, however.... (There is always a however!)
   
   The API: https://cloudstack.apache.org/api/apidocs-4.16/apis/updateStoragePool.html
   
   <pre>
   enabled | false to disable the pool for allocation of new volumes, true to enable it back.
   </pre>
   
   The **enabled** flag only tells if the storage pool should be considered for the allocation of new volumes. It is not intended to be use for not being mounted on hosts. Thats where we have the **maintenance** mode of a storage pool for.
   
   The global setting (mount.disabled.storage.pool defaults to false) which we introduce actually keeps the bug in tact but we can influence the bug by manually changing a config setting.
   
   I would say that we should not add this config value and always 'mount' disabled storage pools as that's how it was designed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org