You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/27 11:00:02 UTC
[GitHub] [rocketmq-dashboard] StyleTang opened a new pull request #14: [Issue #13] Rocketmq-Dashboard License
StyleTang opened a new pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14
Revert the front end resource license modification (c9d4cd1b727 / 635e0ce4d04) and exclude the front end folder from apache-rat-plugin.
(front end resource license can be found in LICENSE file)
## What is the purpose of the change
update Rocketmq-Dashboard License
## Brief changelog
update Rocketmq-Dashboard License
## Verifying this change
Manual test passed
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling merged pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling merged pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14#discussion_r699301209
##########
File path: LICENSE
##########
@@ -413,17 +391,13 @@ Font-Awesome
----------------------
https://github.com/FortAwesome/Font-Awesome
-License
-
-The Font Awesome font is licensed under the SIL OFL 1.1:
-http://scripts.sil.org/OFL
-Font Awesome CSS, LESS, and Sass files are licensed under the MIT License:
-https://opensource.org/licenses/mit-license.html
-The Font Awesome documentation is licensed under the CC BY 3.0 License:
-http://creativecommons.org/licenses/by/3.0/
-Attribution is no longer required as of Font Awesome 3.0, but much appreciated:
-Font Awesome by Dave Gandy - http://fontawesome.io
-Full details: http://fontawesome.io/license/
+Font Awesome Free License
+Font Awesome Free is free, open source, and GPL friendly. You can use it for
Review comment:
The license info is copied from https://fontawesome.com/license/free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14#discussion_r699301209
##########
File path: LICENSE
##########
@@ -413,17 +391,13 @@ Font-Awesome
----------------------
https://github.com/FortAwesome/Font-Awesome
-License
-
-The Font Awesome font is licensed under the SIL OFL 1.1:
-http://scripts.sil.org/OFL
-Font Awesome CSS, LESS, and Sass files are licensed under the MIT License:
-https://opensource.org/licenses/mit-license.html
-The Font Awesome documentation is licensed under the CC BY 3.0 License:
-http://creativecommons.org/licenses/by/3.0/
-Attribution is no longer required as of Font Awesome 3.0, but much appreciated:
-Font Awesome by Dave Gandy - http://fontawesome.io
-Full details: http://fontawesome.io/license/
+Font Awesome Free License
+Font Awesome Free is free, open source, and GPL friendly. You can use it for
Review comment:
The license info is copied from https://fontawesome.com/license/free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14#issuecomment-907548667
@duhenglucky @SteNicholas Would you like to follow the best practices here to optimize the flink and Stream sub-projects :-) I could help to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling commented on a change in pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14#discussion_r697786702
##########
File path: LICENSE
##########
@@ -357,38 +357,16 @@ SOFTWARE.
echarts
----------------------------------
-https://github.com/ecomfe/echarts
-
-Copyright (c) 2017, Baidu Inc.
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this
- list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright notice,
- this list of conditions and the following disclaimer in the documentation
- and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
-ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-The views and conclusions contained in the software and documentation are those
-of the authors and should not be interpreted as representing official policies,
-either expressed or implied, of the FreeBSD Project.
+https://github.com/apache/echarts
+
+ Apache License
Review comment:
Good catch:-0
##########
File path: LICENSE
##########
@@ -413,17 +391,13 @@ Font-Awesome
----------------------
https://github.com/FortAwesome/Font-Awesome
-License
-
-The Font Awesome font is licensed under the SIL OFL 1.1:
-http://scripts.sil.org/OFL
-Font Awesome CSS, LESS, and Sass files are licensed under the MIT License:
-https://opensource.org/licenses/mit-license.html
-The Font Awesome documentation is licensed under the CC BY 3.0 License:
-http://creativecommons.org/licenses/by/3.0/
-Attribution is no longer required as of Font Awesome 3.0, but much appreciated:
-Font Awesome by Dave Gandy - http://fontawesome.io
-Full details: http://fontawesome.io/license/
+Font Awesome Free License
+Font Awesome Free is free, open source, and GPL friendly. You can use it for
Review comment:
less is more. Could we just emphasize copyright here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #14: [Issue #13] Rocketmq-Dashboard License
Posted by GitBox <gi...@apache.org>.
StyleTang commented on a change in pull request #14:
URL: https://github.com/apache/rocketmq-dashboard/pull/14#discussion_r699301209
##########
File path: LICENSE
##########
@@ -413,17 +391,13 @@ Font-Awesome
----------------------
https://github.com/FortAwesome/Font-Awesome
-License
-
-The Font Awesome font is licensed under the SIL OFL 1.1:
-http://scripts.sil.org/OFL
-Font Awesome CSS, LESS, and Sass files are licensed under the MIT License:
-https://opensource.org/licenses/mit-license.html
-The Font Awesome documentation is licensed under the CC BY 3.0 License:
-http://creativecommons.org/licenses/by/3.0/
-Attribution is no longer required as of Font Awesome 3.0, but much appreciated:
-Font Awesome by Dave Gandy - http://fontawesome.io
-Full details: http://fontawesome.io/license/
+Font Awesome Free License
+Font Awesome Free is free, open source, and GPL friendly. You can use it for
Review comment:
The license info is copied from https://fontawesome.com/license/free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org