You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2016/06/05 18:22:52 UTC
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/163
LANG-1197: Prepare Java 9 detection (unfinished)
Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure how to handle this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang java_9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit 96dc0638d5220b7835093d08fdead7d46bee1120
Author: pascalschumacher <pa...@gmx.net>
Date: 2016-05-20T17:29:20Z
LANG-1197: Prepare Java 9 detection (unfinished)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/163
O.k. I will finish this in a few days. This can be merged into the next version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/163#discussion_r65946021
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
/**
* Java 1.9.
+ *
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+ JAVA_1_9(1.9f, "9"),
+
+ /**
+ * Java 9
*/
- JAVA_1_9(1.9f, "1.9"),
+ JAVA_9(1.9f, "9"),
--- End diff --
`1.9f`? This should rather be `9.0f`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
> Not complete: JavaVersion expects the java.version system property to return 1.x but for java 9 it will return 9*. Not sure how to handle this.
I think we should better work with `java.specification.version` here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/163
[](https://coveralls.io/builds/6469522)
Coverage increased (+0.04%) to 93.45% when pulling **96dc0638d5220b7835093d08fdead7d46bee1120 on PascalSchumacher:java_9** into **078e512e6cc5ba49eb3c5a3a63a0ddb657324fd9 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/163
[](https://coveralls.io/builds/7905919)
Coverage decreased (-0.01%) to 93.563% when pulling **b9f04d9be3e7ff300520da194fe29ed5c1861787 on PascalSchumacher:java_9** into **9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/163#discussion_r78301302
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
/**
* Java 1.9.
+ *
+ * @deprecated As of release 3.5, replaced by {@link #JAVA_9}
+ */
+ JAVA_1_9(1.9f, "9"),
+
+ /**
+ * Java 9
*/
- JAVA_1_9(1.9f, "1.9"),
+ JAVA_9(1.9f, "9"),
--- End diff --
I agree with Michael
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/163
[](https://coveralls.io/builds/7905583)
Coverage decreased (-0.01%) to 93.563% when pulling **83d4fce93647b096ce07d4b57489608a7c8a0043 on PascalSchumacher:java_9** into **9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/163
[](https://coveralls.io/builds/7848269)
Coverage increased (+0.2%) to 93.582% when pulling **96dc0638d5220b7835093d08fdead7d46bee1120 on PascalSchumacher:java_9** into **078e512e6cc5ba49eb3c5a3a63a0ddb657324fd9 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...
Posted by PascalSchumacher <gi...@git.apache.org>.
GitHub user PascalSchumacher reopened a pull request:
https://github.com/apache/commons-lang/pull/163
LANG-1197: Prepare Java 9 detection (unfinished)
Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure how to handle this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang java_9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit 96dc0638d5220b7835093d08fdead7d46bee1120
Author: pascalschumacher <pa...@gmx.net>
Date: 2016-05-20T17:29:20Z
LANG-1197: Prepare Java 9 detection (unfinished)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
No, it contains no fix for Java 9 at all :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/163
For the next few days I will probably not have time to finish this and I do not want to hold up the release. Doesn't https://github.com/apache/commons-lang/pull/187/files pull request contain most the code of this pull request anyway?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/163
[](https://coveralls.io/builds/7906006)
Coverage decreased (-0.01%) to 93.563% when pulling **b9f04d9be3e7ff300520da194fe29ed5c1861787 on PascalSchumacher:java_9** into **9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
@PascalSchumacher but why? This was going in the right direction!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/163
@britter I closing this and let you handle the complete java 9 issue(s).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---