You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/11 00:29:11 UTC

[GitHub] [fineract] vorburger opened a new pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702) 

vorburger opened a new pull request #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573415656
 
 
   > why `ShareAccountIntegrationTests` (only) fails on this PR
   
   specifically `testCreateShareAccountWithCharges()` in line 487 `Assert.assertEquals("0.0", String.valueOf(chargeDef.get("amountOutstanding")));` ... I've manually reverted some of the changes of this PR to understand which one causes that failure, and figured it must be related to one of those `hashCode()` and `equals()` changes in `Charge`, `TrialBalance`, `LoanProductProvisioningEntry`, `LoanProductBorrowerCycleVariations` or `ShareAccountCharge`. Hm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573419177
 
 
   The `ShareAccountIntegrationTests.testCreateShareAccountWithCharges()` failure was related to `ShareAccountCharge`, something is really wrong there... to move forward with getting all the rest of the changes proposed here merged ASAP, I've reverted the `hashCode()` and `equals()` changes in `ShareAccountCharge` from here for now; let's pick that up in dedicated [FINERACT-827](https://issues.apache.org/jira/browse/FINERACT-827). With that, I expect that this PR will now pass CI IT (unless it's Sunday, in which case it will fail due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820), which is totally unrelated to everything else here).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
awasum commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573294386
 
 
   Is this still relevant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573551071
 
 
   @awasum this now passed the build (because it's Monday), and is finished and ready from my side.
   
   Will you review and merge this one when you have a moment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger closed pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] awasum merged pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
awasum merged pull request #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger opened a new pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger opened a new pull request #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684
 
 
   based upon code review of changes made by @awasum in previous commit:
   
    - fix clear contains() GC_UNRELATED_TYPES bug in Loan
   
    - fix clear equals() EC_UNRELATED_TYPES bug in Loan
   
    - fix more equals() & hashCode() in...
       * Charge
       * TrialBalance
       * LoanProductBorrowerCycleVariations
       * LoanProductProvisioningEntry
   
    - fix AccountingConstants to avoid using @FindBugsSuppressWarnings
   
    - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings
   
    - fix up weird static in GLAccountBuilder
   
    - minor clean up in build.gradle (spotbugs has replaced findbugs)
   
   PS: This change originally included also fixing the missing `hashCode()` and `equals()` in `ShareAccountCharge`, but that turned out to be non trivial, see [FINERACT-827](https://issues.apache.org/jira/browse/FINERACT-827), and is thus not yet fixed by this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #684:  more SpotBugs related / inspired code clean up (see FINERACT-702) 
URL: https://github.com/apache/fineract/pull/684#issuecomment-573411261
 
 
   > Is this still relevant?
   
   Yes, very much so; this contains more but new SpotBugs related / inspired clean up which I coded on top of your recent work! See #685 re. how this was meant to be reviewed as an addendum to #682 .. now that is in, the diff will look clearer. The Conflicts shown are bogus (I don't really understand why GitHub is that stupid; a simple `git rebase` on the CLI fixes them).
   
   I'm just looking into why `ShareAccountIntegrationTests` (only) fails on this PR. Maybe I'll break it up into smaller ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services