You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Christopher L. Shannon (Jira)" <ji...@apache.org> on 2022/11/01 11:12:00 UTC
[jira] [Comment Edited] (AMQ-9153) Fix Slow Consumer Advisory Test
[ https://issues.apache.org/jira/browse/AMQ-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627108#comment-17627108 ]
Christopher L. Shannon edited comment on AMQ-9153 at 11/1/22 11:11 AM:
-----------------------------------------------------------------------
It looks like this has been broken for 10 years. The change back in 2012 in this Jira AMQ-1902 prevents messages from being dispatched to *queue* subscriptions so the pending cursor ends up being 0 and the logic to detect the slow consumer never is true. It looks like durable subscriptions are fine.
This fix prevents adding to full consumers:
https://github.com/apache/activemq/blob/ba0b7a25a0fb8d225147748f28f69ba5abee01b5/activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java#L2199
This is where the logic is supposed to check if it's slow:
https://github.com/apache/activemq/blob/ba0b7a25a0fb8d225147748f28f69ba5abee01b5/activemq-broker/src/main/java/org/apache/activemq/broker/region/PrefetchSubscription.java#L670
was (Author: christopher.l.shannon):
It looks like this has been broken for 10 years. The change back in 2012 in this Jira AMQ-1902 prevents messages from being dispatched to queue subscriptions so the pending cursor ends up being 0 and the logic to detect the slow consumer never is true.
This fix prevents adding to full consumers:
https://github.com/apache/activemq/blob/ba0b7a25a0fb8d225147748f28f69ba5abee01b5/activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java#L2199
This is where the logic is supposed to check if it's slow:
https://github.com/apache/activemq/blob/ba0b7a25a0fb8d225147748f28f69ba5abee01b5/activemq-broker/src/main/java/org/apache/activemq/broker/region/PrefetchSubscription.java#L670
> Fix Slow Consumer Advisory Test
> -------------------------------
>
> Key: AMQ-9153
> URL: https://issues.apache.org/jira/browse/AMQ-9153
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 5.17.2
> Reporter: Christopher L. Shannon
> Priority: Major
>
> The {{AdvisoryTests}} class was not running due to a bug with the the test configuration that is now fixed in AMQ-9152. The {{testSlowConsumerAdvisory}} test is now failing when run so this needs to be investigated to see if it's a real failure and something broke or if the test needs to be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)