[GitHub] [iceberg] SinghAsDev commented on a change in pull request #3774: [Parquet] Add support to read Parquet files written with old 2-level list structures.

[GitBox <gi...@apache.org>]

SinghAsDev commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r786219905



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetSchemaUtil.java
##########
@@ -164,4 +164,48 @@ public Boolean primitive(PrimitiveType primitive) {
     }
   }
 
+  // Parquet LIST backwards-compatibility rules.
+  // https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules
+  public static boolean isListElementType(Type repeatedType, String parentName) {

Review comment:
       Good point, updating to `isOldListElementType`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org