You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by baibaichen <gi...@git.apache.org> on 2017/03/31 09:19:21 UTC
[GitHub] beam pull request #2391: [BEAM-1846] Update os-maven-plugin to 1.5.0.final+ ...
GitHub user baibaichen opened a pull request:
https://github.com/apache/beam/pull/2391
[BEAM-1846] Update os-maven-plugin to 1.5.0.final+ for building shade file on RHEL/CentOS
The current os-maven-plugin may export the profile with quote on certain versions of centos/RHEL, and it introduces the error when building shade file.
[ERROR]... Error creating shaded jar: The name "os.detected.release.like."centos"" is not legal for JDOM/XML elements: XML names cannot contain the character """. -> [Help 1]
The error is caused by the /etc/os-release which contains some quote. The os-maven-plugin 1.4.1.final+ had fixed it. Therefore, we ought to update the os-maven-plugin to latest verison (1.5.0.fianl) for the user who can\u2019t change the content of the /etc/os-release.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baibaichen/beam feature/fix-build-centos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2391
----
commit dc75e6568be9c7c0de06b4bd5b2ec571b05507d3
Author: Chang chen <ba...@gmail.com>
Date: 2017-03-31T09:16:34Z
[BEAM-1846] Update os-maven-plugin to 1.5.0.final+ for building shade file on RHEL/CentOS
The current os-maven-plugin may export the profile with quote on certain versions of centos/RHEL, and it introduces the error when building shade file.
[ERROR]... Error creating shaded jar: The name "os.detected.release.like."centos"" is not legal for JDOM/XML elements: XML names cannot contain the character """. -> [Help 1]
The error is caused by the /etc/os-release which contains some quote. The os-maven-plugin 1.4.1.final+ had fixed it. Therefore, we ought to update the os-maven-plugin to latest verison (1.5.0.fianl) for the user who can\u2019t change the content of the /etc/os-release.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2391: [BEAM-1846] Update os-maven-plugin to 1.5.0.final+ ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---