You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/08 17:10:13 UTC
[GitHub] [incubator-seatunnel] TaoZex opened a new pull request, #3029: [Improve][Connector-V2][Kafka Sink]custom partition
TaoZex opened a new pull request, #3029:
URL: https://github.com/apache/incubator-seatunnel/pull/3029
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Link https://github.com/apache/incubator-seatunnel/issues/2787
The following code supports two user-defined partition functions:
The first type: the user specifies the partition to send through the partition field in the config (for example, if partition 2 is specified, then the messages are sent to partition 2)
The second: the user customizes the partition through the assign_partitions field in the config
For example, there are 5 partitions in total, and the assign_partitions field in config is as follows:
assignpartitions = ["shoe", "clothing"]
Then the message containing "shoe" will be sent to partition 0 (because "shoe" is subscripted as 0 in assign_partitions), and the message containing "clothing" will be sent to partition 1,
For other messages, the hash algorithm will be used to divide them into the remaining partitions.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3029: [Improve][Connector-V2][Kafka Sink]custom partition
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #3029:
URL: https://github.com/apache/incubator-seatunnel/pull/3029#discussion_r990738532
##########
docs/en/connector-v2/source/IoTDB.md:
##########
@@ -209,4 +209,4 @@ Loaded to SeaTunnelRow data format is the following:
|--------------------|----------------------------|-------------|-------------|
|1664035200001 | root.test_group.device_a | 36.1 | 100 |
|1664035200001 | root.test_group.device_b | 36.2 | 101 |
-|1664035200001 | root.test_group.device_c | 36.3 | 102 |
+|1664035200001 | root.test_group.device_c | 36.3 | 102 |
Review Comment:
revert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex closed pull request #3029: [Improve][Connector-V2][Kafka Sink]custom partition
Posted by GitBox <gi...@apache.org>.
TaoZex closed pull request #3029: [Improve][Connector-V2][Kafka Sink]custom partition
URL: https://github.com/apache/incubator-seatunnel/pull/3029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org