[GitHub] [thrift] fishy commented on pull request #2439: THRIFT-5443: add support for partial Thrift deserialization

[GitBox <gi...@apache.org>]

fishy commented on pull request #2439:
URL: https://github.com/apache/thrift/pull/2439#issuecomment-918752362


   @bhalchandrap for skip: yes please make `TProtocolUtil.skip` choose the most efficient way to skip a field in a TProtocol, instead of adding a new API for "efficient skip" and keep `TProtocolUtil.skip` as the "slow skip".
   
   For partial deserialization, I don't know which makes more sense in Java API. If you can totally use the existing API to implement it that would be awesome (I imagine you at least need to add new constructors to `TDeserializer` to take the field maps you want to partially deserialize). If you can't, I think it's fine to add new APIs for it as long as the new API design makes sense, but the new API should be more similar to the existing `TDeserializer` API, unless we have a good reason to make it quite different (e.g. the current TDeserializer API is bad/inefficient/etc. because of X Y Z).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org