[GitHub] [skywalking] wu-sheng commented on a change in pull request #5132: Improve Es trace basic query performance

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5132:
URL: https://github.com/apache/skywalking/pull/5132#discussion_r463912228



##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/TimeSeriesUtils.java
##########
@@ -55,6 +56,21 @@ public static String latestWriteIndexName(Model model) {
         }
     }
 
+    /**
+     * @return split index name based on time bucket.
+     */
+    public static String[] traceQueryIndices(String indexName, long startSecondTB, long endSecondTB) {

Review comment:
       `traceQueryIndices` -> `recordQueryIndices`

##########
File path: oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/query/TraceQueryEs7DAO.java
##########
@@ -115,7 +116,8 @@ public TraceBrief queryBasicTraces(long startSecondTB,
         sourceBuilder.size(limit);
         sourceBuilder.from(from);
 
-        SearchResponse response = getClient().search(SegmentRecord.INDEX_NAME, sourceBuilder);
+        String[] indices = TimeSeriesUtils.traceQueryIndices(SegmentRecord.INDEX_NAME, startSecondTB, endSecondTB);

Review comment:
       Still, the issue is, currently, we don't ask for time range because of trace id query.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org